Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kubernetes indexers/matchers pluggable #4151

Merged
merged 1 commit into from
May 1, 2017
Merged

Make kubernetes indexers/matchers pluggable #4151

merged 1 commit into from
May 1, 2017

Conversation

vjsamuel
Copy link
Contributor

This PR makes kubernetes indexers/matchers pluggable so that users can write their own plugins and plug them into stock/custom beats

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin
Copy link
Member

ruflin commented May 1, 2017

jenkins, test it

ruflin
ruflin approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vjsamuel Could you share some details on what other indexer / matcher you have in mind?

@vjsamuel
Copy link
Contributor Author

vjsamuel commented May 1, 2017

we have internal indexers that we would want to generate hash values of the dimensions and store them along with the kubernetes metadata. having a plugin interface makes it easier to maintain this code outside the beats repository.

@ruflin
Copy link
Member

ruflin commented May 1, 2017

jenkins, retest it

@ruflin
Copy link
Member

ruflin commented May 1, 2017

Merging as build seems to be all fine except for pushing the artifacts.

@ruflin ruflin merged commit d47c55a into elastic:master May 1, 2017
@vjsamuel vjsamuel deleted the kubernetes_plugins branch May 2, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
:Processors review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vjsamuel @elasticmachine @ruflin @monicasarbu