otelconsumer: adjustments to collector logic and retry/ack unit tests #41457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
botelastic
bot
added
the
needs_team
mauri870
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
mauri870
commented
Oct 25, 2024
mauri870
force-pushed
the
otel-tests
branch
2 times, most recently
from
d4521f9 to
43d6220
Compare
leehinman
reviewed
Oct 25, 2024
The call to `ConsumeLogs` can fail in various ways. If the error is of type "Permanent", retrying will have no effect. For any other error, we need to retry the batch. Additionally, only acknowledge a batch when the collector confirms receipt of the data to avoid losing events.
VihasMakwana
approved these changes
Oct 28, 2024
Member
Author
|
/test |
cmacknz
reviewed
Oct 28, 2024
cmacknz
approved these changes
Oct 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…#41457) The call to `ConsumeLogs` can fail in various ways. If the error is of type "Permanent", retrying will have no effect. For any other error, we need to retry the batch. Additionally, only acknowledge a batch when the collector confirms receipt of the data to avoid losing events. (cherry picked from commit e20e486)
Merged
6 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 29, 2024
…#41457) (#41476) The call to `ConsumeLogs` can fail in various ways. If the error is of type "Permanent", retrying will have no effect. For any other error, we need to retry the batch. Additionally, only acknowledge a batch when the collector confirms receipt of the data to avoid losing events. (cherry picked from commit e20e486) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The call to
ConsumeLogscan fail in various ways. If the error is of type "Permanent", retrying will have no effect. For any other error, we need to retry the batch. Additionally, only acknowledge a batch when the collector confirms receipt of the data to avoid losing events.CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
batch.Drop()in the permanent error case, should I handle it in a different way?Related issues