Awscloudwatchtags

[gizas]

• Enhancement

Proposed commit message

Reopening the PR in order to merge #40755
Due to building errors (#33913 (comment)) the initial PR had been reverted

Related issues

• Closes #Metricbeat not collecting tags for AWS - Apigateway resource_type:restapis #33913

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b awscloudwatchtags upstream/awscloudwatchtags
git merge upstream/main
git push upstream awscloudwatchtags

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gizas? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[gizas]

@elastic/beats-tech-leads can I have an approval please?

[cmacknz]

This is deprecated and goes EOL in July 2025, when you'll be forced to remove it because it won't get security updates (or I guess you could wait until there is a CVE reported in it and then urgently remove it): https://github.com/aws/aws-sdk-go

This PR also makes agentbeat 5% larger. Do we really need both versions of the AWS SDK?

~/go/src/github.com/elastic/beats/x-pack/agentbeat main
❯ du -h agentbeat
216M    agentbeat

~/go/src/github.com/elastic/beats/x-pack/agentbeat awscloudwatchtags
❯ du -h agentbeat
227M    agentbeat

[gizas]

The whole idea of this fix was that we needed to query both Rest APIs (that were included in old sdk) and WebSocket and HTTP APIs (that are included in the v2 sdk) in case user needed the metadata
(See code for check)

Let me doublecheck again and let you know. I am not still merging this

[gizas]

@cmacknz I was not accurate, the https://github.com/aws/aws-sdk-go was not needed. Now it is removed!

Long explanation:

I was wrongly using aws.StringValue (See old commit) from old sdk, in order to be safe with nill pointer exception

I found a replacer with aws.Tostring from new sdk (see new code)

Just to clarify for the following code, both functions use aws-sdk-go-v2 but:

• GetAPIGatewayRestAPIOutput : Uses package apigateway ("github.com/aws/aws-sdk-go-v2/service/apigateway")
• GetAPIGatewayAPIOutput: Uses package apigatewayv2 ("github.com/aws/aws-sdk-go-v2/service/apigatewayv2")