Skip to content

Conversation

@kilfoyle
Copy link
Contributor

This docs PR updates the various percentage fields on the Metricbeat Docker fields page to indicate that the scale is 0 - 1, rather than 0 - 100.

I'm not set up to run the docs generation script, so I've updated both the Yaml source and the corresponding Asciidoc output.

Closes: #12411

@kilfoyle kilfoyle added docs Team:Docs Label for the Observability docs team backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Oct 21, 2024
@kilfoyle kilfoyle requested a review from a team as a code owner October 21, 2024 14:48
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 21, 2024
@kilfoyle kilfoyle requested a review from beiske October 21, 2024 14:49
@kilfoyle
Copy link
Contributor Author

kilfoyle commented Oct 21, 2024

check-docs CI check fails with:

Error: some files are not up-to-date. Run 'make update' then review and commit the changes. Modified: [metricbeat/docs/fields.asciidoc

Would anyone with a Beats dev environment set up mind running make update so that this can pass CI? 🙏

@pierrehilbert pierrehilbert requested review from rdner and removed request for khushijain21 October 21, 2024 15:17
@beiske
Copy link
Member

beiske commented Oct 22, 2024

Thank you @kilfoyle

@rdner rdner requested review from a team as code owners October 23, 2024 12:19
@rdner rdner requested review from constanca-m and gizas October 23, 2024 12:19
@rdner rdner enabled auto-merge (squash) October 23, 2024 12:19
@rdner
Copy link
Member

rdner commented Oct 23, 2024

@elastic/obs-infraobs-integrations can someone please have a look?

@pierrehilbert
Copy link
Contributor

cc @lalit-satapathy

@rdner rdner merged commit e440450 into elastic:main Oct 24, 2024
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)
rdner pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)

Co-authored-by: David Kilfoyle <[email protected]>
rdner pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)

Co-authored-by: David Kilfoyle <[email protected]>
rdner pushed a commit that referenced this pull request Oct 24, 2024
Update docs and generated files

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit e440450)

Co-authored-by: David Kilfoyle <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify docs Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that pct values are scaled between 0 and 1 and not 0 and 100

6 participants