Fix error handling and add nolint comment #41256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
bug
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
VihasMakwana
approved these changes
Oct 16, 2024
rdner
reviewed
Oct 16, 2024
Co-authored-by: Denis <[email protected]>
rdner
approved these changes
Oct 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
--------- Co-authored-by: Denis <[email protected]> (cherry picked from commit c1fc9a9)
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 16, 2024
--------- Co-authored-by: Denis <[email protected]> (cherry picked from commit c1fc9a9) Co-authored-by: Tiago Queiroz <[email protected]>
belimawr
added a commit
to belimawr/beats
that referenced
this pull request
Oct 18, 2024
--------- Co-authored-by: Denis <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's Checklist## How to test this PR locallyRelated issues
## Use cases## Screenshots## Logs