[8.x](backport #41206) [Filebeat] [AWS] add support to source logs from AWS linked source accounts when using log_group_name_prefix #41247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…counts when using log_group_name_prefix (#41206) * configuration parsing to support arn & linked accounts Signed-off-by: Kavindu Dodanduwa <[email protected]> # Conflicts: # x-pack/filebeat/input/awscloudwatch/input.go * code review change - fix typo Signed-off-by: Kavindu Dodanduwa <[email protected]> * add support to linked accounts when using prefix mode Signed-off-by: Kavindu Dodanduwa <[email protected]> * add changelog entry Signed-off-by: Kavindu Dodanduwa <[email protected]> * review suggestion Signed-off-by: Kavindu Dodanduwa <[email protected]> * use non-pointer struct property Signed-off-by: Kavindu Dodanduwa <[email protected]> --------- Signed-off-by: Kavindu Dodanduwa <[email protected]> (cherry picked from commit 7e1b528)
mergify
bot
requested review from
faec and
mauri870
and removed request for
a team
botelastic
bot
added
the
needs_team
Kavindu-Dodan
approved these changes
Oct 15, 2024
Kavindu-Dodan
added
the
Team:obs-ds-hosted-services
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
botelastic
bot
removed
the
needs_team
pierrehilbert
approved these changes
Oct 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This is a follow-up to #41188 where I am adding support to source linked accounts when using
log_group_name_prefixto derive log groups.PR introduce
include_linked_accounts_for_prefix_modeboolean property, which is disabled by default. If enabled (include_linked_accounts_for_prefix_mode : true), then we setincludeLinkedAccountsproperty of the DescribeLogGroups API [1] to obtain log groups matching prefix and included in linked accounts of the monitoring account.ex:-
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
This require a linked cloudwatch account. If already has one, then,
CLOUDWATCH_LOG) [2]log_group_name_prefixwith desired prefix & setinclude_linked_accounts_for_prefix_modeto valuetrue(enabled)Related issues
[1] - https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_DescribeLogGroups.html
[2] - https://github.com/Kavindu-Dodan/data-gen
This is an automatic backport of pull request #41206 done by Mergify.