Create nil cgroups reader for processor, improve error handling #41198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
fearful-symmetry
added
the
Team:Security-Linux Platform
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
botelastic
bot
removed
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
4 tasks
leehinman
approved these changes
Oct 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
* create nil reader, improve error handling * add test, clean up * linter (cherry picked from commit 764ba96) # Conflicts: # filebeat/autodiscover/defaults_aix.go # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go
Merged
4 tasks
fearful-symmetry
added a commit
that referenced
this pull request
Oct 14, 2024
* create nil reader, improve error handling * add test, clean up * linter
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ve error handling (#41205) * Create nil cgroups reader for processor, improve error handling (#41198) * create nil reader, improve error handling * add test, clean up * linter (cherry picked from commit 764ba96) # Conflicts: # filebeat/autodiscover/defaults_aix.go # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go * Revert "Create nil cgroups reader for processor, improve error handling (#41198)" This reverts commit 0b886fc. * Create nil cgroups reader for processor, improve error handling (#41198) * create nil reader, improve error handling * add test, clean up * linter --------- Co-authored-by: Alex K <[email protected]> Co-authored-by: fearful-symmetry <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Continuation of #41189 . This adds a
NilCGReadertype that makes us a little less likely to hit a nil pointer deref if this code is changed in the future, and also cleans up some of the error handling.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.