Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2024

Proposed commit message

This PR is to change GetListMetricsOutput function (which calls the ListMetrics API) to use namespaces when namespaces are given in AWS CloudWatch configuration in Metricbeat.

Instead of returning all possible metrics from CloudWatch from ALL namespaces and filter later, we only need to query the ListMetrics API to get the metrics under the namespaces that we care about.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #41022 done by [Mergify](https://mergify.com).

* Use namespace for GetListMetrics when exists

(cherry picked from commit 36327a4)
@mergify mergify bot requested a review from a team as a code owner October 8, 2024 14:45
@mergify mergify bot added the backport label Oct 8, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 8, 2024
@botelastic
Copy link

botelastic bot commented Oct 8, 2024

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng merged commit 1311999 into 8.x Oct 8, 2024
@kaiyan-sheng kaiyan-sheng deleted the mergify/bp/8.x/pr-41022 branch October 8, 2024 15:56
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants