Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

Proposed commit message

This PR changes log.file.path field in awscloudwatch input from dotted field to nested object.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

The concern we have with this PR is when users have ingest pipelines or logstash filters configured down the line, this might break what they have. For example in ingest pipeline, ctx[‘log.file.path’] needs to be changed to ctx.log?.file?.path.


This is an automatic backport of pull request #41099 done by Mergify.

…ect (#41099)

Change log.file.path field in awscloudwatch input to nested object

(cherry picked from commit 904d14b)

# Conflicts:
#	x-pack/filebeat/input/awscloudwatch/input_test.go
@mergify mergify bot requested a review from a team as a code owner October 7, 2024 22:24
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 7, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Oct 7, 2024

Cherry-pick of 904d14b has failed:

On branch mergify/bp/8.x/pr-41099
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 904d14b664.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   x-pack/filebeat/input/awscloudwatch/processor.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/filebeat/input/awscloudwatch/input_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2024
@botelastic
Copy link

botelastic bot commented Oct 7, 2024

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng merged commit e4e0a1e into 8.x Oct 8, 2024
@kaiyan-sheng kaiyan-sheng deleted the mergify/bp/8.x/pr-41099 branch October 8, 2024 13:51
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants