Skip to content

[8.x](backport #41152) Revert "Don't register cfgfile flags on flag.CommandLine in func init()" #41161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leehinman merged 1 commit into from
Oct 7, 2024
Merged

[8.x](backport #41152) Revert "Don't register cfgfile flags on flag.CommandLine in func init()" #41161

leehinman merged 1 commit into from
Oct 7, 2024

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024 •
edited by zube bot
Loading

Reverts #40993

Due to elastic/apm-server#14214 and elastic/apm-server#14280

This is an automatic backport of pull request #41152 done by Mergify.

@leehinman @mergify
Revert "Don't register cfgfile flags on flag.CommandLine in `func i…
d7c6474 
…nit()`" (#41152)

* Revert "Don't register cfgfile flags on `flag.CommandLine` in `func init()` (…"

This reverts commit 07360ca.

* linter fixes

(cherry picked from commit 2ff38df)
@mergify mergify bot requested a review from a team as a code owner October 7, 2024 20:19
@mergify mergify bot added the backport label Oct 7, 2024
@mergify mergify bot requested review from faec and leehinman and removed request for a team October 7, 2024 20:19
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2024
@botelastic
Copy link

botelastic bot commented Oct 7, 2024

This pull request doesn't have a Team:<team> label.

@leehinman leehinman enabled auto-merge (squash) October 7, 2024 20:20
@leehinman leehinman merged commit 67bbb70 into 8.x Oct 7, 2024
@leehinman leehinman deleted the mergify/bp/8.x/pr-41152 branch October 7, 2024 21:58
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@leehinman leehinman

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leehinman