[8.x](backport #39405) [metricbeat] [helper] Fix http server helper SSL config #41157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The TLS config used in the metricbeat http server module uses a TLS config suitable for clients (
BuildModuleClientConfig), not for servers. This makes it impossible to successfully connect to Prometheusremote_writeusing TLS sincebad certificateis always returned.Made some small unrelated changes to make
golangci-linthappy. Added a reasonableReadHeaderTimeoutof 10 seconds. Replacedioutilwithio.This was tested with
openssl s_clientand also directly with theremote_writedata stream.The
NewHttpServeris also used by thehttpmodule.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #39405 done by [Mergify](https://mergify.com).