Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 4, 2024

Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #41110 done by [Mergify](https://mergify.com).

…41110)

Detection of data stream identity was using os.PathSeparator which will
not match the path separator used by embed.FS which is always "/"[1].

[1]https://pkg.go.dev/embed#hdr-Directives

(cherry picked from commit f55bd8d)
@mergify mergify bot requested a review from a team as a code owner October 4, 2024 09:57
@mergify mergify bot added the backport label Oct 4, 2024
@mergify mergify bot assigned efd6 Oct 4, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2024
@botelastic
Copy link

botelastic bot commented Oct 4, 2024

This pull request doesn't have a Team:<team> label.

@efd6 efd6 merged commit 8f62854 into 8.x Oct 4, 2024
@efd6 efd6 deleted the mergify/bp/8.x/pr-41110 branch October 4, 2024 10:34
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants