-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix cgroup helper init in add_processor_metadata and add_docker_metadata processors
#41108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cgroup helper init in add_processor_metadata and add_docker_metadata processors
#41108
Conversation
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
belimawr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my area of expertise, but LGTM.
I've seen the same CI error transaction_log_integration_test.go:22: timeout waiting for services to be healthy in one of my PRs, so I believe it's related to this one.
…tadata` processors (#41108) * only initialize cgroup reader once * docs * remove old struct fields --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit 13d71a6)
|
@fearful-symmetry Thank you so much! |
|
This PR seems to break MAC os development of beats if any of the metadata processors are enabled. In my setup, I get |
…tadata` processors (#41108) (#41185) * only initialize cgroup reader once * docs * remove old struct fields --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit 13d71a6) Co-authored-by: Alex K. <[email protected]>
Proposed commit message
Closes #41065
This refactors
add_processor_metadataandadd_docker_metadataso we only callNewReaderonce when we create a new processor, and not every time the processor runs. This should considerably cut down on CPU cycles for certain workloads, sinceNewReaderhas gotten much more complex over the years.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.