Add linting for the replace directive in go.mod#41086
Merged
ycombinator merged 2 commits intoelastic:mainfrom Oct 3, 2024
ycombinator:lint-replace
Merged
Add linting for the replace directive in go.mod#41086ycombinator merged 2 commits intoelastic:mainfrom ycombinator:lint-replace
replace directive in go.mod#41086ycombinator merged 2 commits intoelastic:mainfrom
ycombinator:lint-replace
Conversation
botelastic
bot
added
the
needs_team
ycombinator
added
release-note:skip
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
leehinman
approved these changes
Oct 3, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Forbid local replaces in go.mod * Restrict replaced dependencies in go.mod to an allowlist (cherry picked from commit 28169ee)
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 4, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This change introduces linting for the
replacedirective ingo.mod. It forbids local replacements (generally used as temporary measures during development) and it adds an allowlist for permanent replacements to restrict the dependencies that may be replaced.Related: #41084 and #41085