Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Type of change

  • Enhancement

Proposed commit message

  • WHAT: Simplified state checkpoint calculation
  • WHY: The existing state checkpoint calculation logic was convoluted and depended on unreliable flag logic, then it has been simplified so that if errors occur they are become simpler to debug.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #40936 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 2, 2024 03:11
@mergify mergify bot added the backport label Oct 2, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2024
@botelastic
Copy link

botelastic bot commented Oct 2, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor Author

mergify bot commented Oct 7, 2024

This pull request has not been merged yet. Could you please review and merge it @ShourieG? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Oct 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-40936 upstream/mergify/bp/8.x/pr-40936
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-40936

@ShourieG ShourieG merged commit 7cf1e16 into 8.x Oct 8, 2024
@ShourieG ShourieG deleted the mergify/bp/8.x/pr-40936 branch October 8, 2024 04:24
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants