Conversation
|
This pull request doesn't have a |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @ShourieG? 🙏 |
ShourieG
approved these changes
Oct 8, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
Added support for Microsoft Entra ID RBAC authentication.
Added mock tests by injecting the gock transport layer in the azure client.
Added some config tests with the new config options.
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
No Impact
Live Testing
Live testing was performed using our internal Azure dev environment.
Process followed:
Author's Checklist
How to test this PR locally
Related issues
Testing
We performed live testing internally using an active azure account and the new authentication system is working properly after assigning the service principal app with the blobOwner permission level.
Use cases
Screenshots
Logs
This is an automatic backport of pull request #40879 done by [Mergify](https://mergify.com).