Skip to content

fix(auditbeat): only create ebpfreader on supported linux platforms #41040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kruskall merged 3 commits into from
Oct 11, 2024
Merged

fix(auditbeat): only create ebpfreader on supported linux platforms #41040

kruskall merged 3 commits into from
Oct 11, 2024

Conversation

@kruskall
Copy link
Member

@kruskall kruskall commented Sep 29, 2024 •
edited
Loading

Proposed commit message

ebpf reader/watcher is only supported on linux amd64/arm64
to avoid compile errors on other systems return an error if the ebpf backend is requested and ebpf is not supported

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kruskall
fix(auditbeat): only create ebpfreader on supported linux platforms
0c98edd 
ebpf reader/watcher is only supported on linux amd64/arm64
to avoid compile errors on other systems return an error
if the ebpf backend is requested and ebpf is not supported
@kruskall kruskall requested review from a team as code owners September 29, 2024 02:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 29, 2024
@pierrehilbert pierrehilbert added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Linux Platform Linux Platform Team in Security Solution labels Sep 29, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 29, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 29, 2024

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2024
andrewkroh
andrewkroh approved these changes Oct 10, 2024
View reviewed changes
@kruskall kruskall enabled auto-merge (squash) October 10, 2024 22:38
@kruskall kruskall merged commit 575c7cc into elastic:main Oct 11, 2024
@kruskall kruskall deleted the fix/ebpf-reader-compile-error branch October 11, 2024 00:16
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@kruskall @mergify
fix(auditbeat): only create ebpfreader on supported linux platforms (#…
f59f48f 
…41040)

* fix(auditbeat): only create ebpfreader on supported linux platforms

ebpf reader/watcher is only supported on linux amd64/arm64
to avoid compile errors on other systems return an error
if the ebpf backend is requested and ebpf is not supported

* lint: newEbpfReader -> newEBPFReader

(cherry picked from commit 575c7cc)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
6 tasks
pierrehilbert pushed a commit that referenced this pull request Oct 11, 2024
@mergify @kruskall
fix(auditbeat): only create ebpfreader on supported linux platforms (#…
1f3976c 
…41040) (#41199)

* fix(auditbeat): only create ebpfreader on supported linux platforms

ebpf reader/watcher is only supported on linux amd64/arm64
to avoid compile errors on other systems return an error
if the ebpf backend is requested and ebpf is not supported

* lint: newEbpfReader -> newEBPFReader

(cherry picked from commit 575c7cc)

Co-authored-by: kruskall <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@mauri870 mauri870 mauri870 approved these changes

@faec faec faec approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

Assignees

@kruskall kruskall

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kruskall @elasticmachine @andrewkroh @mauri870 @faec @VihasMakwana @pierrehilbert