Skip to content

feat: bump gopsutil to current major version#41024

Merged
kruskall merged 1 commit intoelastic:mainfrom
kruskall:bump/gopsutil
Nov 21, 2024
Merged

feat: bump gopsutil to current major version#41024
kruskall merged 1 commit intoelastic:mainfrom
kruskall:bump/gopsutil

Conversation

@kruskall
Copy link
Member

Proposed commit message

v3 is no longer supported, bump to current major version

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kruskall kruskall requested review from a team as code owners September 27, 2024 02:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 27, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 27, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 27, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump/gopsutil upstream/bump/gopsutil
git merge upstream/main
git push upstream bump/gopsutil

@cmacknz
Copy link
Member

cmacknz commented Oct 2, 2024

Looking at the changelogs there are a good number of changes and bug fixes that would potentially affect the system module.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump/gopsutil upstream/bump/gopsutil
git merge upstream/main
git push upstream bump/gopsutil

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump/gopsutil upstream/bump/gopsutil
git merge upstream/main
git push upstream bump/gopsutil

v3 is no longer supported, bump to current major version
@kruskall
Copy link
Member Author

kruskall commented Nov 19, 2024

Looking at the changelogs there are a good number of changes and bug fixes that would potentially affect the system module.

@cmacknz do you want me to add a changelog entry or is it ok to merge ? 🤔

@kruskall kruskall merged commit 842c411 into elastic:main Nov 21, 2024
@kruskall kruskall deleted the bump/gopsutil branch November 21, 2024 17:55
mergify bot pushed a commit that referenced this pull request Nov 21, 2024
v3 is no longer supported, bump to current major version

(cherry picked from commit 842c411)
@cmacknz
Copy link
Member

cmacknz commented Nov 21, 2024

do you want me to add a changelog entry or is it ok to merge ?

I don't think there are any user facing functional changes, I was more wondering if they were contributing to test failures.

kruskall added a commit that referenced this pull request Nov 21, 2024
v3 is no longer supported, bump to current major version

(cherry picked from commit 842c411)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants