Skip to content

Enable type assertion checks #41021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ycombinator merged 1 commit into from
Sep 27, 2024
Merged

Enable type assertion checks #41021

ycombinator merged 1 commit into from
Sep 27, 2024

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Sep 26, 2024

This PR (re)enables the errcheck.check-type-assertions linter, in light of #41009

@ycombinator ycombinator requested a review from a team as a code owner September 26, 2024 22:18
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 26, 2024
@ycombinator ycombinator added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 26, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 26, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 26, 2024
@ycombinator ycombinator requested a review from rdner September 26, 2024 22:18
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 26, 2024
@ycombinator ycombinator merged commit 5ec48fa into elastic:main Sep 27, 2024
@ycombinator ycombinator deleted the lint-type-assertion branch September 27, 2024 13:20
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
@ycombinator @mergify
Enable type assertion checks (#41021)
3abb2e0 
(cherry picked from commit 5ec48fa)
@mergify mergify bot mentioned this pull request Sep 27, 2024
Merged
ycombinator added a commit that referenced this pull request Sep 27, 2024
@mergify @ycombinator
Enable type assertion checks (#41021) (#41028)
b123b58 
(cherry picked from commit 5ec48fa)

Co-authored-by: Shaunak Kashyap <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@mauri870 mauri870 mauri870 approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

@blakerouse blakerouse Awaiting requested review from blakerouse

@jlind23 jlind23 Awaiting requested review from jlind23

@pchila pchila Awaiting requested review from pchila

@rdner rdner Awaiting requested review from rdner

Assignees

@ycombinator ycombinator

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ycombinator @elasticmachine @pierrehilbert @mauri870