Skip to content

[8.x](backport #40360) [kibana] support api_key #40914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrehilbert merged 2 commits into from
Sep 30, 2024
Merged

[8.x](backport #40360) [kibana] support api_key #40914

pierrehilbert merged 2 commits into from
Sep 30, 2024

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024 •
edited by zube bot
Loading

Summary

Adds support for api_key authentication in the kibana module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • create an api key and grab the beats format[1]
  • configure kibana module to use that api_key:
metricbeat.modules:
  - module: kibana
    xpack.enabled: true
    hosts: ["http://localhost:9200"]
    api_key: <key in beats format>
    period: 10s
  • kibana metricsets are successfully collecting documents

[1]
Screenshot 2023-08-09 at 17 23 25

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40360 done by [Mergify](https://mergify.com).

@sachinfrayne @VihasMakwana @mergify
[kibana] support api_key (#40360)
ae54e55 
* [kibana] support api_key

* changes username and password to generic values

* make check formatting changes

* removes skip-go-installation option

* fixes: naked return in func

* adds skip-go-installation back

* only sets header if apikey is not empty

---------

Co-authored-by: VihasMakwana <[email protected]>
(cherry picked from commit f934ab8)
@mergify mergify bot added the backport label Sep 20, 2024
@mergify mergify bot requested review from a team as code owners September 20, 2024 07:12
@mergify mergify bot removed the request for review from a team September 20, 2024 07:12
@mergify mergify bot requested review from khushijain21 and mauri870 September 20, 2024 07:12
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Sep 23, 2024

This pull request has not been merged yet. Could you please review and merge it @sachin-frayne? 🙏

@pierrehilbert pierrehilbert added the Team:Monitoring Stack Monitoring team label Sep 23, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 23, 2024
@pierrehilbert pierrehilbert requested review from sachinfrayne and removed request for khushijain21 and mauri870 September 23, 2024 06:58
sachinfrayne
sachinfrayne approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@sachinfrayne sachinfrayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor Author

mergify bot commented Sep 30, 2024

This pull request has not been merged yet. Could you please review and merge it @sachin-frayne? 🙏

@pierrehilbert pierrehilbert merged commit 2479dc5 into 8.x Sep 30, 2024
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-40360 branch September 30, 2024 07:08
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

+1 more reviewer

@sachinfrayne sachinfrayne sachinfrayne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sachinfrayne sachinfrayne

Labels

backport Team:Monitoring Stack Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierrehilbert @sachinfrayne