Skip to content

Conversation

@pchila
Copy link
Member

@pchila pchila commented Sep 17, 2024

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No disruption as the disk queue was already unsupported when running under agent

Author's Checklist

  • [ ]

How to test this PR locally

Package agent using beats binaries that include this change.
Install agent as standalone and modify the output in elastic-agent.yml

outputs:
  default:
    type: elasticsearch
    hosts: [127.0.0.1:9200]
    api_key: "example-key"
    #username: "elastic"
    #password: "changeme"
## Note: we need to disable the preset otherwise it will override queue.disk with queue.mem setting
    #preset: balanced
    queue.disk:
        max_size: 1GB

Add a beats input (filebeat or other) that uses the output and the disk queue will appear under the input data directory, for example:

root@elastic-agent-dev:/opt/Elastic/Agent/data/elastic-agent-9.0.0-SNAPSHOT-d99b09/run/filestream-default/diskqueue# ll
total 8
drwxr-xr-x 2 root root 4096 Sep 17 09:18 ./
drwxrwx--- 4 root root 4096 Sep 17 09:18 ../
-rw------- 1 root root    0 Sep 17 09:18 state.dat

Related issues

Use cases

Screenshots

Logs

@pchila pchila requested a review from a team as a code owner September 17, 2024 13:50
@pchila pchila self-assigned this Sep 17, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2024
@pchila pchila added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pchila pchila added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pchila? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 17, 2024
@cmacknz cmacknz added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-8.15 Automated backport to the 8.15 branch with mergify labels Sep 17, 2024
@pierrehilbert pierrehilbert requested review from leehinman and removed request for khushijain21 September 18, 2024 07:16
@pchila pchila merged commit cf83386 into elastic:main Sep 18, 2024
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
* Expose output disk queue settings when running under agent

(cherry picked from commit cf83386)
pchila added a commit that referenced this pull request Sep 23, 2024
…40888)

* Expose output disk queue settings when running under agent

(cherry picked from commit cf83386)

Co-authored-by: Paolo Chilà <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants