[8.x](backport #40753) fix invalid bitSize in strconv.ParseFloat #40773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bitSize argument in strconv.ParseFloat should be either 32 or 64. Any value other than 32 will default to 64 in the current implementation, though this behavior is undocumented, making it undefined. See https://cs.opensource.google/go/go/+/refs/tags/go1.23.0:src/strconv/atof.go;l=704-708. (cherry picked from commit 6e93c27)
mergify
bot
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
botelastic
bot
added
the
needs_team
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
mauri870
requested review from
mauri870
and removed request for
AndersonQ and
VihasMakwana
mauri870
approved these changes
Sep 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The bitSize argument in strconv.ParseFloat should be either 32 or 64.
Any value other than 32 will default to 64 in the current implementation,
though this behavior is undocumented, making it undefined.
See https://cs.opensource.google/go/go/+/refs/tags/go1.23.0:src/strconv/atof.go;l=704-708.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.This is an automatic backport of pull request fix invalid bitSize in strconv.ParseFloat #40753 done by Mergify.