Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Sep 10, 2024

Proposed commit message

Otherwise, backport-skip or any other backport- labels could have higher precedence and then backport-v8.x will not be attached.
If backport-8.x should always be there for any PRs targeting main, then this should help with.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@v1v v1v requested a review from ycombinator September 10, 2024 18:07
@v1v v1v self-assigned this Sep 10, 2024
@v1v v1v requested a review from a team as a code owner September 10, 2024 18:07
@v1v v1v requested a review from rdner September 10, 2024 18:07
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2024
@botelastic
Copy link

botelastic bot commented Sep 10, 2024

This pull request doesn't have a Team:<team> label.

@ycombinator
Copy link
Contributor

Hi @v1v, just wanted to check, how is this PR functionally different from #40718?

@v1v
Copy link
Member Author

v1v commented Sep 10, 2024

Hi @v1v, just wanted to check, how is this PR functionally different from #40718?

I think there is one edge case:

Someone can create a PR targeting main and add one backport-* label immediately after. In that case, the automation might not add the label backport-v8.x, see L134.

$ gh pr create --label backport-skip --fill --base main

I assume that an edge case could happen, so I decided to raise this PR to play it safe. Therefore, any new PR targeting main will be tagged with backport-v8.x regardless.

@ycombinator
Copy link
Contributor

Gotcha. Makes sense. Thanks for thinking of the edge case and creating this PR (and similar ones in other repos too)!

@v1v v1v merged commit a94ff04 into elastic:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants