-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.x](backport #40707) Update fields to use mapstr in vSphere virtualmachine metricset #40724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Convert fields to mapstr * lint changes * Address comments, update changelog * lint change * Address CI failure (cherry picked from commit e7637c0) # Conflicts: # metricbeat/module/vsphere/fields.go # metricbeat/module/vsphere/virtualmachine/_meta/data.json # metricbeat/module/vsphere/virtualmachine/data.go # metricbeat/module/vsphere/virtualmachine/data_test.go # metricbeat/module/vsphere/virtualmachine/virtualmachine.go
|
Cherry-pick of e7637c0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
This pull request doesn't have a |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @ishleenk17? 🙏 |
2 similar comments
|
This pull request has not been merged yet. Could you please review and merge it @ishleenk17? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @ishleenk17? 🙏 |
9ac1d95 to
3dd9ecf
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
ishleenk17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring lint errors as they were not present in the actual PR.
Proposed commit message
See title
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.This is an automatic backport of pull request #40707 done by [Mergify](https://mergify.com).