Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 17, 2024

Proposed commit message

Added the v8-format-compliant status.overall.level field in the metrics.
The v8 format was the default starting... ehem... v8.0.0 😅

While I was at it, I also added status.overall.summary for a human-friendlier explanation of the status.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

The new field (and values) needs to be used in alerts/visualizations. Refer to elastic/kibana#76054 for more information about the breaking changes.

Related issues

Use cases

Stack Monitoring.

cc @elastic/kibana-core @elastic/stack-monitoring


This is an automatic backport of pull request #40275 done by [Mergify](https://mergify.com).

(cherry picked from commit 942f8c7)

# Conflicts:
#	metricbeat/module/kibana/fields.go
@mergify mergify bot requested a review from a team as a code owner July 17, 2024 18:55
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 17, 2024
@mergify mergify bot assigned afharo Jul 17, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Jul 17, 2024

Cherry-pick of 942f8c7 has failed:

On branch mergify/bp/8.8/pr-40275
Your branch is up to date with 'origin/8.8'.

You are currently cherry-picking commit 942f8c7857.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   metricbeat/docs/fields.asciidoc
	modified:   metricbeat/module/kibana/status/_meta/fields.yml
	new file:   metricbeat/module/kibana/status/_meta/testdata/8.16.0.json
	new file:   metricbeat/module/kibana/status/_meta/testdata/8.16.0.json-expected.json
	modified:   metricbeat/module/kibana/status/data.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   metricbeat/module/kibana/fields.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2024
@botelastic
Copy link

botelastic bot commented Jul 17, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor Author

mergify bot commented Jul 22, 2024

This pull request has not been merged yet. Could you please review and merge it @afharo? 🙏

@afharo afharo closed this Jul 22, 2024
@afharo afharo deleted the mergify/bp/8.8/pr-40275 branch July 22, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants