Add elasticsearch node_stats metricset #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,60 @@ | |||
| package node_stats | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
don't use an underscore in package name
There was a problem hiding this comment.
We should ignore this lint error, right?
There was a problem hiding this comment.
yes, because we have also other packages with this kind of names. @7AC can we configure it to ignore these errors?
| @@ -0,0 +1,35 @@ | |||
| // +build !integration | |||
|
|
|||
| package node_stats | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
don't use an underscore in package name
| @@ -0,0 +1,51 @@ | |||
| package node_stats | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
don't use an underscore in package name
ruflin
force-pushed
the
add-elasticsearch-nodestats-metricset
branch
from
43057a5
to
2d1d359
Compare
|
jenkins, retest it |
andrewkroh
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.