[AWS] Add include_linked_accounts config parameter for ListMetrics API#35648
Merged
kaiyan-sheng merged 11 commits intoelastic:mainfrom Jun 2, 2023
Merged
[AWS] Add include_linked_accounts config parameter for ListMetrics API#35648kaiyan-sheng merged 11 commits intoelastic:mainfrom
kaiyan-sheng merged 11 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
girodav
approved these changes
Jun 2, 2023
Contributor
girodav
left a comment
There was a problem hiding this comment.
Made some changes directly on the PR to speed things up. Thanks for this Kaiyan :)
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
cmacknz
approved these changes
Jun 2, 2023
Member
cmacknz
left a comment
There was a problem hiding this comment.
Approving the config and docs changes.
Contributor
|
I think we can remove the backport to 8.7 |
kaiyan-sheng
added a commit
that referenced
this pull request
Jun 2, 2023
…eter for ListMetrics API (#35663) Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng
added a commit
that referenced
this pull request
Jun 2, 2023
…eter for ListMetrics API (#35664) Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Merged
4 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add
include_linked_accountsconfig parameter intoawsmodule.Default isDefault istruefor this config so metrics from linked accounts will always be collected.falseChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
How to test it
include_linked_accountsconfig and by default (false) we should not collect any metrics from linked accounts.include_linked_accounts = falseconfig and we should not collect any metrics from linked accounts.include_linked_accounts = trueconfig and we should see metrics from all linked accounts.