Skip to content

[AWS] Add include_linked_accounts config parameter for ListMetrics API#35648

Merged
kaiyan-sheng merged 11 commits intoelastic:mainfrom
kaiyan-sheng:add_include_linked_accounts
Jun 2, 2023
Merged

[AWS] Add include_linked_accounts config parameter for ListMetrics API#35648
kaiyan-sheng merged 11 commits intoelastic:mainfrom
kaiyan-sheng:add_include_linked_accounts

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 1, 2023

What does this PR do?

This PR is to add include_linked_accounts config parameter into aws module. Default is true for this config so metrics from linked accounts will always be collected. Default is false

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

How to test it

  1. Test without include_linked_accounts config and by default (false) we should not collect any metrics from linked accounts.
  2. Test with include_linked_accounts = false config and we should not collect any metrics from linked accounts.
  3. Test with include_linked_accounts = true config and we should see metrics from all linked accounts.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 1, 2023
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 1, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 1, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-02T19:41:21.551+0000

  • Duration: 92 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 4658
Skipped 1022
Total 5680

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jun 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2023
@girodav girodav self-requested a review June 2, 2023 08:40
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review June 2, 2023 12:10
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 2, 2023 12:10
@kaiyan-sheng kaiyan-sheng added backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify labels Jun 2, 2023
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 2, 2023 12:58
@kaiyan-sheng kaiyan-sheng requested review from cmacknz and rdner June 2, 2023 12:58
Copy link
Copy Markdown
Contributor

@girodav girodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes directly on the PR to speed things up. Thanks for this Kaiyan :)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 2, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_include_linked_accounts upstream/add_include_linked_accounts
git merge upstream/main
git push upstream add_include_linked_accounts

Copy link
Copy Markdown
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the config and docs changes.

@andresrc
Copy link
Copy Markdown
Contributor

andresrc commented Jun 2, 2023

I think we can remove the backport to 8.7

@kaiyan-sheng kaiyan-sheng removed the backport-v8.7.0 Automated backport with mergify label Jun 2, 2023
@kaiyan-sheng kaiyan-sheng merged commit 1dcc62a into elastic:main Jun 2, 2023
@kaiyan-sheng kaiyan-sheng deleted the add_include_linked_accounts branch June 2, 2023 21:19
@kaiyan-sheng kaiyan-sheng added the backport-v8.7.0 Automated backport with mergify label Jun 2, 2023
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
kaiyan-sheng added a commit that referenced this pull request Jun 2, 2023
…eter for ListMetrics API (#35663)


Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request Jun 2, 2023
…eter for ListMetrics API (#35664)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants