filebeat/scripts/mage - Remove installation of journald deps from crossBuild#34939
Merged
andrewkroh merged 2 commits intoelastic:mainfrom Mar 28, 2023
Merged
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
…ssBuild The golang-crossbuild images contain the journald development dependencies so the build steps do not need make changes to the environment before building. Fixes elastic#34938
548a8ef to
33fbe01
Compare
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
rdner
approved these changes
Mar 28, 2023
Member
|
I didn't know we could just remove them :) |
This will help prevent merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.
Fixes #34938
Why is it important?
Packaging builds are failing.(see #34938 (comment))Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
cd filebeat; SNAPSHOT=true mage -v packageRelated issues