Add support for optional metricsets in xpack mode#34273
Merged
joshdover merged 7 commits intoelastic:mainfrom Jan 24, 2023
Merged
Add support for optional metricsets in xpack mode#34273joshdover merged 7 commits intoelastic:mainfrom
joshdover merged 7 commits intoelastic:mainfrom
Conversation
10 tasks
Contributor
joshdover
commented
Jan 19, 2023
Contributor
Author
|
@klacabane friendly bump here if you have some time to review |
6 tasks
Contributor
|
Thanks for separating out this change. I'm good with moving forward with it. I think eventually we should extend it this logic to make it possible to also disable metricsets that are on by default but we can do this in a follow up. |
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds support for specifying that a metricset can also be enabled when
xpack.enabled: trueis set, but is not turned on by default. This allows for finer-grained control of when a metricset is enabled when using xpack mode. For example this will allow support for a configuration like:This only affects the
beat,elasticsearch,kibana, andlogstashmodules for Stack Monitoring.Why is it important?
We are adding a new ingest metricset as "beta" in #34012. We want to be able to enable/disable this on Cloud deployments as we do testing. Since Cloud uses
xpack.enabled: truewe need a new way to have control over which metricsets are enabled.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Not possible yet since there's no metricsets using this
Related issues