Skip to content

Enforce "yes" when install debian packages in packaging#33895

Merged
rdner merged 1 commit intoelastic:mainfrom
rdner:enforce-yes-packaging
Nov 30, 2022
Merged

Enforce "yes" when install debian packages in packaging#33895
rdner merged 1 commit intoelastic:mainfrom
rdner:enforce-yes-packaging

Conversation

@rdner
Copy link
Copy Markdown
Member

@rdner rdner commented Nov 30, 2022

Older versions of Debian have expired GPG keys. In this case -y is not enough and apt-get requires an additional --force-yes.

Why is it important?

Packaging jobs fail on 7.17 due to this flag missing https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fpackaging/detail/PR-33843/4/pipeline/150/

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files~- [ ] I have added tests that prove my fix is effective or that my feature works~ ~- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc`.

Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.
@rdner rdner added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 30, 2022
@rdner rdner self-assigned this Nov 30, 2022
@rdner rdner requested a review from a team as a code owner November 30, 2022 19:17
@rdner rdner requested review from belimawr and cmacknz and removed request for a team November 30, 2022 19:17
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2022
@rdner rdner force-pushed the enforce-yes-packaging branch from de53ef3 to 6154447 Compare November 30, 2022 19:25
Copy link
Copy Markdown
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a follow up task to upgrade the Debian version we are using? I suspect the answer is yes.

@rdner
Copy link
Copy Markdown
Member Author

rdner commented Nov 30, 2022

@cmacknz I've tried doing that before. It requires a big re-work of the integration tests.

If we're talking about this particular change, we need to update our custom images, see here https://github.com/elastic/beats/blob/main/dev-tools/mage/crossbuild.go#L222-L247

e.g. docker.elastic.co/beats-dev/golang-crossbuild:1.18.5-darwin-debian10

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Nov 30, 2022

FYI @v1v looks like we need to update the Debian base image of the crossbuild containers, we are just working around it for now.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T19:25:53.159+0000

  • Duration: 68 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 25056
Skipped 1954
Total 27010

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner merged commit 6c0dc97 into elastic:main Nov 30, 2022
@rdner rdner deleted the enforce-yes-packaging branch November 30, 2022 20:36
mergify Bot pushed a commit that referenced this pull request Nov 30, 2022
Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)
mergify Bot pushed a commit that referenced this pull request Nov 30, 2022
Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)
mergify Bot pushed a commit that referenced this pull request Nov 30, 2022
Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)
@elasticmachine
Copy link
Copy Markdown
Contributor

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T19:17:30.718+0000

  • Duration: 86 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 25059
Skipped 1954
Total 27013

Steps errors 1

Expand to view the steps failures

x-pack/winlogbeat-windows-2016-windows-2016 - Install Python
  • Took 0 min 20 sec . View more details here
  • Description: .ci/scripts/install-tools.bat

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz pushed a commit that referenced this pull request Dec 1, 2022
)

Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
rdner added a commit that referenced this pull request Dec 1, 2022
)

Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
rdner added a commit that referenced this pull request Dec 1, 2022
)

Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.

(cherry picked from commit 6c0dc97)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
@rdner
Copy link
Copy Markdown
Member Author

rdner commented Dec 1, 2022

@cmacknz @v1v I can see that there was already an attempt to fix the version for Auditbeat only but it was not backported to 7.17 due to some compatibility issues #23872

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Older versions of Debian have expired GPG keys. In this case `-y` is
not enough and `apt-get` requires an additional `--force-yes`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants