-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker provider add_fields processors #33269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
bug
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
labels
Oct 6, 2022
belimawr
requested review from
aleksmaus and
michalpristas
and removed request for
a team
October 6, 2022 09:45
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 6, 2022
8 tasks
belimawr
force-pushed
the
fix-docker-provider
branch
from
October 6, 2022 09:49
e991e14
to
7411d71
Compare
Collaborator
/package |
/test |
2 similar comments
/test |
/test |
belimawr
force-pushed
the
fix-docker-provider
branch
from
October 10, 2022 10:16
7411d71
to
751eb6a
Compare
The Docker provider was using a wrong key when defining the `add_fields` processor, this causes Filebeat not to start the input and stay on a unhealthy state. This processor seems to be defined every time a variable like `${docker}` is used on a input configuration. This commig fixes it.
belimawr
force-pushed
the
fix-docker-provider
branch
from
October 11, 2022 09:18
751eb6a
to
46238f3
Compare
cmacknz
approved these changes
Oct 12, 2022
I'll merge this because only the e2e tests are failing and they're know to be flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for: elastic/elastic-agent#1420
What does this PR do?
The Docker provider was using a wrong key when defining the
add_fields
processor, this causes Filebeat not to start the input and stay on a unhealthy state. This processor seems to be defined every time a variable like${docker}
is used on a input configuration.This commit fixes it.
Why is it important?
It fixes a bug on Docker auto discovery provider
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
docker run --rm --name flog -d mingrammer/flog /bin/flog -s1 -d1 -l -f rfc3164
)./var/lib/docker/containers/${docker.container.id}/*-json.log
./tmp/elastic-agent.yml
), adjust the Elasticsearch credentials as needed./var/lib/docker/*)
:Related issues
## Use cases## Screenshots## Logs