fix: mage installation with go1.18 by v1v · Pull Request #33083 · elastic/beats

v1v · 2022-09-14T16:19:16Z

What does this PR do?

go1.18 changed where the packages are installed when using go install
Run the same command in the CI pipeline

Why is it important?

The UR for 7.17 is broken for the last 5 days.

Installing mage v1.13.0.
make[3]: Leaving directory '/var/lib/jenkins/workspace/elastic+unified-release+master+snapshot-beats-7.17/cd/release/release-manager/project-configs/7.17/build/projects/gopath/src/github.com/elastic/beats/libbeat'
bash: mage: command not found
make[3]: [../dev-tools/make/mage-install.mk:11: mage] Error 127 (ignored)
bash: mage: command not found
make[3]: *** [scripts/Makefile:33

Test

echo  1.17.10 > .go-version
./dev-tools/run_with_go_ver make test-mage 
...

## Variables

GOOS             = darwin
GOARCH           = amd64
GOARM            = 
Platform         = darwin/amd64
BinaryExt        = 
XPackDir         = ../x-pack

echo  1.18.5 > .go-version
./dev-tools/run_with_go_ver make test-mage 
...

## Variables

GOOS             = darwin
GOARCH           = amd64
GOARM            = 
Platform         = darwin/amd64
BinaryExt        = 
XPackDir         = ../x-pack
BeatName         = beats
BeatServiceName  = beats
## Functions

beat_doc_branch              = 7.17
beat_version                 = 7.17.7
commit                       = 0390d5708dec5ef6c7c721af0c29e6a4bc28261d
date                         = 2022-09-14T17:37:17Z
elastic_beats_dir            = /Users/vmartinez/work/src/github.com/elastic/beats
go_version                   = 1.18.5

Additionally, I tested on docker, to be the more platform agnostic as possible, see #33083 (comment)

Issues

Caused by #32693

botelastic · 2022-09-14T16:19:21Z

This pull request doesn't have a Team:<team> label.

elasticmachine · 2022-09-14T16:26:08Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-14T17:33:03.123+0000
Duration: 73 min 53 sec

Test stats 🧪

Test	Results
Failed	0
Passed	22149
Skipped	1563
Total	23712

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz

Thanks! I noticed this errors in the logs but never got around to figuring out why they were there.

v1v · 2022-09-14T17:25:58Z

I'm still fixing it ...

$ docker run --rm -ti -v `pwd`:/src/github.com/elastic/beats -w /src/github.com/elastic/beats ubuntu
$ apt-get update ; apt-get install -y curl make build-essential  ; HOME=/src ./dev-tools/run_with_go_ver make test-mage
+ /src/bin/gvm 1.17.10
+ cut -d ' ' -f 2
+ tr -d '\"'


++ /src/bin/gvm 1.17.10
+ eval 'export GOROOT="/src/.gvm/versions/go1.17.10.linux.amd64"
export PATH="/src/.gvm/versions/go1.17.10.linux.amd64/bin:$PATH"'
++ export GOROOT=/src/.gvm/versions/go1.17.10.linux.amd64
++ GOROOT=/src/.gvm/versions/go1.17.10.linux.amd64
++ export PATH=/src/.gvm/versions/go1.17.10.linux.amd64/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ PATH=/src/.gvm/versions/go1.17.10.linux.amd64/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
...

## Functions

beat_doc_branch              = {{ beat_doc_branch }}
beat_version                 = {{ beat_version }}
commit                       = {{ commit }}
date                         = {{ date }}
elastic_beats_dir            = {{ elastic_beats_dir }}
go_version                   = {{ go_version }}
repo.RootImportPath          = {{ repo.RootImportPath }}
repo.CanonicalRootImportPath = {{ repo.CanonicalRootImportPath }}
repo.RootDir                 = {{ repo.RootDir }}

v1v · 2022-09-14T17:33:06Z

Jenkinsfile

+            dir("${BASE_DIR}") {
+              sh "HOME=${WORKSPACE} GO_VERSION=${GO_VERSION} ./dev-tools/run_with_go_ver make test-mage"
+            }


v1v · 2022-09-14T17:34:52Z

@cmacknz , I think this will be ready to be merged, somehow my initial thoughts were about the GOPATH, but the issue was related to go install. I'll be offline in a bit, so this PR could be merged as soon as it gets green, you don't need to wait for me, in case the release team wanna build 7.17 sooner than later, otherwise I'll merge it first thing tomorrow morning

v1v · 2022-09-21T15:22:15Z

@Mergifyio backport main

v1v · 2022-09-21T15:22:24Z

@Mergifyio backport 8.5

v1v · 2022-09-21T15:22:32Z

@Mergifyio backport 8.4

mergify · 2022-09-21T15:23:01Z

backport main

✅ Backports have been created

Details

#33149 fix: mage installation with go1.18 (backport #33083) has been created for branch main

mergify · 2022-09-21T15:23:02Z

backport 8.5

❌ No backport have been created

Details

Backport to branch 8.5 failed: Branch not found

* path for the mage with go1.18 has changed * ci: test the command in the CI pipeline * ci: set HOME * new make goal to validate the mage installation * unrequired path when using go install (cherry picked from commit 5385fd2) # Conflicts: # Jenkinsfile

mergify · 2022-09-21T15:23:42Z

backport 8.4

✅ Backports have been created

Details

#33150 fix: mage installation with go1.18 (backport #33083) has been created for branch 8.4

v1v · 2022-09-21T18:34:31Z

@Mergifyio backport 8.5

* path for the mage with go1.18 has changed * ci: test the command in the CI pipeline * ci: set HOME * new make goal to validate the mage installation * unrequired path when using go install (cherry picked from commit 5385fd2) # Conflicts: # Jenkinsfile

mergify · 2022-09-21T18:35:01Z

backport 8.5

✅ Backports have been created

Details

#33159 fix: mage installation with go1.18 (backport #33083) has been created for branch 8.5

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

v1v added 2 commits September 14, 2022 17:11

path for the mage with go1.18 has changed

5393b29

ci: test the command in the CI pipeline

2f2c6a2

v1v requested review from a team and cmacknz September 14, 2022 16:19

v1v requested a review from a team as a code owner September 14, 2022 16:19

v1v requested review from belimawr and removed request for a team September 14, 2022 16:19

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 14, 2022

v1v self-assigned this Sep 14, 2022

v1v added the bug label Sep 14, 2022

cmacknz approved these changes Sep 14, 2022

View reviewed changes

v1v added 2 commits September 14, 2022 17:53

ci: set HOME

454e95f

new make goal to validate the mage installation

a3d04c9

unrequired path when using go install

0390d57

v1v commented Sep 14, 2022

View reviewed changes

v1v requested a review from cmacknz September 14, 2022 17:34

cmacknz approved these changes Sep 14, 2022

View reviewed changes

cmacknz merged commit 5385fd2 into elastic:7.17 Sep 14, 2022

mergify bot mentioned this pull request Sep 21, 2022

fix: mage installation with go1.18 (backport #33083) #33149

Merged

mergify bot mentioned this pull request Sep 21, 2022

fix: mage installation with go1.18 (backport #33083) #33150

Merged

v1v pushed a commit that referenced this pull request Sep 21, 2022

fix: mage installation with go1.18 (backport #33083) (#33149)

d49292d

v1v pushed a commit that referenced this pull request Sep 21, 2022

fix: mage installation with go1.18 (backport #33083) (#33150)

b2bbdbb

mergify bot mentioned this pull request Sep 21, 2022

fix: mage installation with go1.18 (backport #33083) #33159

Closed

michalpristas mentioned this pull request Nov 9, 2022

[backport 8.5] Fix installation of mage with go 1.18 #33619

Merged

michalpristas added a commit that referenced this pull request Nov 9, 2022

fix: mage installation with go1.18 (backport #33083) (#33149) (#33619)

f81376b

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

fix: mage installation with go1.18 (backport #33083) (#33149)

2159372

Conversation

v1v commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Test

Issues

Uh oh!

botelastic bot commented Sep 14, 2022

Uh oh!

elasticmachine commented Sep 14, 2022 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

cmacknz left a comment

Choose a reason for hiding this comment

Uh oh!

v1v commented Sep 14, 2022

Uh oh!

v1v Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

v1v commented Sep 14, 2022

Uh oh!

v1v commented Sep 21, 2022

Uh oh!

v1v commented Sep 21, 2022

Uh oh!

v1v commented Sep 21, 2022

Uh oh!

mergify bot commented Sep 21, 2022

✅ Backports have been created

Uh oh!

mergify bot commented Sep 21, 2022

❌ No backport have been created

Uh oh!

mergify bot commented Sep 21, 2022

✅ Backports have been created

Uh oh!

v1v commented Sep 21, 2022

Uh oh!

mergify bot commented Sep 21, 2022

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

v1v commented Sep 14, 2022 •

edited

Loading

elasticmachine commented Sep 14, 2022 •

edited by jenkins-beats-ci bot

Loading