[Metricbeat] GCP refactor getFilterForMetric ifelse to switch#33047
Merged
gpop63 merged 3 commits intoelastic:mainfrom Sep 15, 2022
Merged
[Metricbeat] GCP refactor getFilterForMetric ifelse to switch#33047gpop63 merged 3 commits intoelastic:mainfrom
gpop63 merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
endorama
reviewed
Sep 12, 2022
CHANGELOG.next.asciidoc
Outdated
| - Fix and improve AWS metric period calculation to avoid zero-length intervals {pull}32724[32724] | ||
| - Add network name to data.json {pull}32986[32986] | ||
| - Add missing cluster metadata to k8s module metricsets {pull}32979[32979] | ||
| - GCP refactor getFilterForMetric ifelse to switch {pull}33047[33047] |
Contributor
There was a problem hiding this comment.
This changeset does not require a changelog, as no functionality changes, so you could remove this.
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
This reverts commit ba6fec4.
endorama
approved these changes
Sep 14, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* refactor getFilterForMetric ifelse to switch * add changelog entry * Revert "add changelog entry" This reverts commit ba6fec4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors
getFilterForMetricif else cases to switch cases as requested by @endorama #32964 (comment)Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs