Skip to content

Refactor endpoint resolver for AWS services #32921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francescayeye merged 11 commits into from
Sep 8, 2022
Merged

Refactor endpoint resolver for AWS services #32921

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c0f32c8
Add signing region
sayden Aug 30, 2022
9818f62
Add changelog entry
sayden Aug 30, 2022
90d16ec
Merge branch 'main' into aws-fix-region-not-being-used
sayden Aug 30, 2022
4f3ba46
remove awscommon.EnrichAWSConfigWithEndpoint
Aug 31, 2022
1632a7e
add nonAWSBucketResolver when recreating the s3 client for new region
Aug 31, 2022
cfe0656
remove unused functions
Aug 31, 2022
5da6d9d
changelog
Aug 31, 2022
fd07efc
fix changelog
Aug 31, 2022
a0138b5
Merge branch 'main' into aws-fix-region-not-being-used
Sep 1, 2022
0c8c76e
fix docs
Sep 6, 2022
f20e833
Merge branch 'main' into aws-fix-region-not-being-used
Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]
*Affecting all Beats*

- Fix namespacing on self-monitoring {pull}32336[32336]

- Fix SigningRegion not being used in AWS credentials {pull}32921[32921] {issue}32888[32888]

*Auditbeat*

Expand Down
2 changes: 1 addition & 1 deletion x-pack/libbeat/common/aws/credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func EnrichAWSConfigWithEndpoint(endpoint string, serviceName string, regionName

beatsConfig.EndpointResolverWithOptions = awssdk.EndpointResolverWithOptionsFunc(
func(service, region string, options ...interface{}) (awssdk.Endpoint, error) {
return awssdk.Endpoint{URL: eurl}, nil
return awssdk.Endpoint{URL: eurl, SigningRegion: region}, nil
Comment thread
kaiyan-sheng marked this conversation as resolved.
Outdated
})
}
return beatsConfig
Expand Down