[8.4](backport #32724) Fix a couple of bugs in the logic for how AWS metric periods are calculated#32872
Merged
kaiyan-sheng merged 1 commit into8.4from Aug 26, 2022
Merged
Conversation
…ulated (#32724) * Fix a couple of bugs in the logic for how AWS metric periods are calcuated. Firstly, we clarify that periods are always whole-minute durations. Any period that is less than or in between minutes is rounded up to the next whole-minute. Secondly, we ensure that the resulting time period is always in the past. This stops us getting empty metrics for the current-minute period. Thirdly, we follow the AWS guidelines of aligning periods to whole multiples within the hour e.g. 10:25->10:30 instead of 10:27->10:32 for a 5 minute period. * add test that validates intervals are continuous for given periods * update changelog * fix merge error (cherry picked from commit df3733e)
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #32724 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com