Skip to content

Update go 1.18 fixes#32653

Merged
cmacknz merged 9 commits intoelastic:update-go-version-20220802092450-mainfrom
cmacknz:update-go-1.18-fixes
Aug 10, 2022
Merged

Update go 1.18 fixes#32653
cmacknz merged 9 commits intoelastic:update-go-version-20220802092450-mainfrom
cmacknz:update-go-1.18-fixes

Conversation

@cmacknz
Copy link
Member

@cmacknz cmacknz commented Aug 10, 2022

Same as #32611 but retargeted to the Go 1.18.5 branch instead of the Go 1.18.4 branch.

Done to allow updating to OpenJDK 11 to ensure compatibility with the
output from keytool on my local machine that used a much more recent
version of OpenJDK.
The certificates were previously signed with SHA-1 which is deprecated
in Go 1.18 due to being insecure.
Updates the linter targets to auto upgrade when the linter version
changes.
@cmacknz cmacknz self-assigned this Aug 10, 2022
@cmacknz cmacknz requested a review from a team as a code owner August 10, 2022 17:57
@cmacknz cmacknz requested review from belimawr and fearful-symmetry and removed request for a team August 10, 2022 17:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2022
@botelastic
Copy link

botelastic bot commented Aug 10, 2022

This pull request doesn't have a Team:<team> label.

@cmacknz cmacknz merged commit 7b145bb into elastic:update-go-version-20220802092450-main Aug 10, 2022
@cmacknz cmacknz deleted the update-go-1.18-fixes branch August 10, 2022 17:58
mergify bot pushed a commit that referenced this pull request Aug 15, 2022
* [Automation] Update go release version to 1.18.5

* Merge Go 1.18 fixes (#32653)

* Update Kafka base image to Debian buster.

Done to allow updating to OpenJDK 11 to ensure compatibility with the
output from keytool on my local machine that used a much more recent
version of OpenJDK.

* Regenerate Kafka certs to use SHA-256.

The certificates were previously signed with SHA-1 which is deprecated
in Go 1.18 due to being insecure.

* Rename test cases so they can be run  individually

* Upgrade golangci-lint in actions.

* Update notice file.

* Fix misplaced changelog entry.

* Add release note for Go 1.18 upgrade.

* Upgrade to elastic-agent-libs v0.2.11

Updates the linter targets to auto upgrade when the linter version
changes.

* Work around errorlint bug in wineventlog pkg.

errorlint does not correctly parse indexed fmt verbs when they have a
verb modifier.

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 56ca6f5)

# Conflicts:
#	.github/workflows/golangci-lint.yml
#	.go-version
#	.golangci.yml
#	NOTICE.txt
#	auditbeat/Dockerfile
#	go.mod
#	go.sum
#	heartbeat/Dockerfile
#	libbeat/docs/version.asciidoc
#	metricbeat/Dockerfile
#	packetbeat/Dockerfile
#	winlogbeat/sys/wineventlog/publisher_metadata.go
#	winlogbeat/sys/wineventlog/syscall_windows.go
#	x-pack/functionbeat/Dockerfile
tommyers-elastic pushed a commit to tommyers-elastic/beats that referenced this pull request Aug 16, 2022
* [Automation] Update go release version to 1.18.5

* Merge Go 1.18 fixes (elastic#32653)

* Update Kafka base image to Debian buster.

Done to allow updating to OpenJDK 11 to ensure compatibility with the
output from keytool on my local machine that used a much more recent
version of OpenJDK.

* Regenerate Kafka certs to use SHA-256.

The certificates were previously signed with SHA-1 which is deprecated
in Go 1.18 due to being insecure.

* Rename test cases so they can be run  individually

* Upgrade golangci-lint in actions.

* Update notice file.

* Fix misplaced changelog entry.

* Add release note for Go 1.18 upgrade.

* Upgrade to elastic-agent-libs v0.2.11

Updates the linter targets to auto upgrade when the linter version
changes.

* Work around errorlint bug in wineventlog pkg.

errorlint does not correctly parse indexed fmt verbs when they have a
verb modifier.

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz added a commit that referenced this pull request Sep 8, 2022
…#32693)

* [automation] Update go release version 1.18.5 (#32574)

* [Automation] Update go release version to 1.18.5

* Merge Go 1.18 fixes (#32653)

* Update Kafka base image to Debian buster.

Done to allow updating to OpenJDK 11 to ensure compatibility with the
output from keytool on my local machine that used a much more recent
version of OpenJDK.

* Regenerate Kafka certs to use SHA-256.

The certificates were previously signed with SHA-1 which is deprecated
in Go 1.18 due to being insecure.

* Rename test cases so they can be run  individually

* Upgrade golangci-lint in actions.

* Update notice file.

* Fix misplaced changelog entry.

* Add release note for Go 1.18 upgrade.

* Upgrade to elastic-agent-libs v0.2.11

Updates the linter targets to auto upgrade when the linter version
changes.

* Work around errorlint bug in wineventlog pkg.

errorlint does not correctly parse indexed fmt verbs when they have a
verb modifier.

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 56ca6f5)

# Conflicts:
#	.github/workflows/golangci-lint.yml
#	.go-version
#	.golangci.yml
#	NOTICE.txt
#	auditbeat/Dockerfile
#	go.mod
#	go.sum
#	heartbeat/Dockerfile
#	libbeat/docs/version.asciidoc
#	metricbeat/Dockerfile
#	packetbeat/Dockerfile
#	winlogbeat/sys/wineventlog/publisher_metadata.go
#	winlogbeat/sys/wineventlog/syscall_windows.go
#	x-pack/functionbeat/Dockerfile

* Resolve conficts, bump go.mod to version 1.18.

* Fix conflict in .go-version

* Bump mage version to match go.mod

* Bump mage to latest version.

* Remove unnecessary packages.

* Update notice.

* Run mage fmt update for winlogbeat

Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* [Automation] Update go release version to 1.18.5

* Merge Go 1.18 fixes (#32653)

* Update Kafka base image to Debian buster.

Done to allow updating to OpenJDK 11 to ensure compatibility with the
output from keytool on my local machine that used a much more recent
version of OpenJDK.

* Regenerate Kafka certs to use SHA-256.

The certificates were previously signed with SHA-1 which is deprecated
in Go 1.18 due to being insecure.

* Rename test cases so they can be run  individually

* Upgrade golangci-lint in actions.

* Update notice file.

* Fix misplaced changelog entry.

* Add release note for Go 1.18 upgrade.

* Upgrade to elastic-agent-libs v0.2.11

Updates the linter targets to auto upgrade when the linter version
changes.

* Work around errorlint bug in wineventlog pkg.

errorlint does not correctly parse indexed fmt verbs when they have a
verb modifier.

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant