Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query count to metricbeat's mysql plugin output #3251

Merged
merged 5 commits into from
Jan 3, 2017
Merged

Add query count to metricbeat's mysql plugin output #3251

merged 5 commits into from
Jan 3, 2017

Conversation

st1t
Copy link
Contributor

@st1t st1t commented Dec 28, 2016

Hello everyone.
Fix to issue the number of Query when using metricbeat 's MySQL module.
Since Com_select and Com_insert etc. are integrated values, we can not grasp the number of queries per second or every minute.
I was wondering whether this difference value should be implemented with metricbeat.
However, since the time interval you want to display is different, I'd like to adjust on the timelion side.

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@tsg
Copy link
Contributor

tsg commented Jan 2, 2017

jenkins, test it

@@ -3463,6 +3463,40 @@ type: long



[float]
== com Fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about "com". Perhaps we could name it "commands" or "queries"? @ruflin, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like command, but would keep it singular.

@ruflin ruflin added Metricbeat Metricbeat review labels Jan 2, 2017
@ruflin
Copy link
Member

ruflin commented Jan 2, 2017

Could you update the CHANGELOG?

@st1t
Copy link
Contributor Author

st1t commented Jan 2, 2017

Thank you for appending advice and code!😀
Now I do not have a pc at hand, so I will fix it later.

@ruflin
Copy link
Member

ruflin commented Jan 3, 2017

jenkins, test it

@tsg tsg merged commit bbee3fe into elastic:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants