[filebeat][httpjson] Add google.jwt_json option to httpjson input#31750
Merged
marc-gr merged 9 commits intoelastic:mainfrom Jun 1, 2022
Merged
[filebeat][httpjson] Add google.jwt_json option to httpjson input#31750marc-gr merged 9 commits intoelastic:mainfrom
marc-gr merged 9 commits intoelastic:mainfrom
Conversation
botelastic
bot
added
the
needs_team
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
Merged
4 tasks
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
reviewed
May 25, 2022
- Use os pkg instead of ioutil - Check ErrNotExist with errors.Is - Check for length with != 0 - Factor out json file function
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…1750) * Add google.jwt_json option to httpjson input * Set PR number in changelog * Amend comments: - Use os pkg instead of ioutil - Check ErrNotExist with errors.Is - Check for length with != 0 - Factor out json file function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
auth.oauth2.google.jwt_jsonoption to thehttpjsoninput.Why is it important?
For some setups (ie: integrations) is more convenient to define the ServiceAccount JWT directly in the config instead of placing a file in the host. This option was already available for regular credentials (
auth.oauth2.google.credentials_json) but was not present for ServiceAccount setups.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Relates elastic/integrations#2834