Skip to content

packetbeat: move "protocol" term from event.category to event.type in SIP events#31599

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:3343-packetbeat-sip
May 12, 2022
Merged

packetbeat: move "protocol" term from event.category to event.type in SIP events#31599
efd6 merged 2 commits intoelastic:mainfrom
efd6:3343-packetbeat-sip

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 12, 2022 •
edited
Loading

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Packetbeat Team:Security-External Integrations 8.3-candidate backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels May 12, 2022
@efd6 efd6 self-assigned this May 12, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 12, 2022
@efd6 efd6 changed the title packetbeat: move "protocol" term from event.category to event.type in… packetbeat: move "protocol" term from event.category to event.type in SIP events May 12, 2022
@efd6 efd6 force-pushed the 3343-packetbeat-sip branch from f936f8c to 4f3d674 Compare May 12, 2022 02:05
@elasticmachine
Copy link
Contributor

elasticmachine commented May 12, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T02:52:18.384+0000

  • Duration: 52 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 1668
Skipped 19
Total 1687

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review May 12, 2022 03:53
@efd6 efd6 requested a review from a team as a code owner May 12, 2022 03:53
@elasticmachine
Copy link
Contributor

elasticmachine commented May 12, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 mentioned this pull request May 12, 2022
Merged
4 tasks
r00tu53r
r00tu53r approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efd6 efd6 merged commit fa0ad8f into elastic:main May 12, 2022
mergify bot pushed a commit that referenced this pull request May 12, 2022
@efd6 @mergify
packetbeat: move "protocol" term from event.category to event.type in…
026f2f7 
… SIP events (#31599)

(cherry picked from commit fa0ad8f)
@mergify mergify bot mentioned this pull request May 12, 2022
Merged
mergify bot pushed a commit that referenced this pull request May 12, 2022
@efd6 @mergify
packetbeat: move "protocol" term from event.category to event.type in…
6800d2b 
… SIP events (#31599)

(cherry picked from commit fa0ad8f)
@mergify mergify bot mentioned this pull request May 12, 2022
Merged
efd6 added a commit that referenced this pull request May 12, 2022
@mergify @efd6
packetbeat: move "protocol" term from event.category to event.type in…
3f7d4ca 
… SIP events (#31599) (#31601)

(cherry picked from commit fa0ad8f)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
efd6 added a commit that referenced this pull request May 12, 2022
@mergify @efd6
[8.2](backport #31599) packetbeat: move "protocol" term from event.ca…
ad8770b 
…tegory to event.type in SIP events (#31602)

* packetbeat: move "protocol" term from event.category to event.type in SIP events (#31599)

(cherry picked from commit fa0ad8f)

* silence linter

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
packetbeat: move "protocol" term from event.category to event.type in…
ac16584 
… SIP events (#31599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

8.3-candidate backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.2.0 Automated backport with mergify bug Packetbeat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @r00tu53r