Cherry-pick #28695 to 8.0: [filebeat][httpjson] Set url as a pointer to ensure access to all methods#30574
Merged
marc-gr merged 1 commit intoelastic:8.0from Feb 24, 2022
Merged
Conversation
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
…hods (elastic#28695) * Set url as a pointer to ensure access to all methods * Add changelog line * Fix text (cherry picked from commit 47dba85)
7033e9b to
5861ebf
Compare
Contributor
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #28695 to 8.0 branch. Original message:
What does this PR do?
Change how
urlis stored in the request context, from value to pointer.Why is it important?
In templates methods with a pointer receiver are not available if the variable is passed by value, making access to
.url.Queryand others impossible.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.