Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Feb 21, 2022

What does this PR do?

This removes the majority of unused identified by running:

staticcheck -checks 'U*' ./{,x-pack/}winlogbeat/...

Care has been taken to not remove platform-specific code and mage-required code.

This is the auditbeat part of #30483.

Why is it important?

Deadcode reduces code base maintainability.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • The first commit is purely mechanical and can be verified by running git-generate with that commit checked out.
  • The second commit should be checked with the view to save deletions from the gallows. I will add lint ignore directives for chunks that are to be retained and revert those chunks.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

efd6 added 2 commits February 21, 2022 13:55
[git-generate]
gofumpt -w ./{,x-pack/}winlogbeat
This removes the majority of unused identified by running:

staticcheck -checks 'U*' ./{,x-pack/}winlogbeat/...

Care has been taken to not remove platform-specific code and mage-required code.
@efd6 efd6 added cleanup Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.2-candidate labels Feb 21, 2022
@efd6 efd6 requested a review from andrewkroh February 21, 2022 04:21
@efd6 efd6 requested a review from a team as a code owner February 21, 2022 04:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 21, 2022
@mergify mergify bot assigned efd6 Feb 21, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-21T04:21:33.148+0000

  • Duration: 134 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 32921
Skipped 3308
Total 36229

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 128cbf4 into elastic:main Feb 22, 2022
@efd6 efd6 deleted the gardenlintwinlog branch February 22, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.2-candidate backport-skip Skip notification from the automated backport with mergify cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants