Filebeat tests: Restore @timestamp field validation
#29772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the `@timestamp` field in Filebeat's module tests, so that it is properly validated.
This fileset is failing to extract the correct timestamp from the logs. This will be fixed in a separate PR.
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label. Could you fix it @adriansr? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
adriansr
changed the title
@timestamp field validation@timestamp field validation
P1llus
approved these changes
Jan 10, 2022
6 tasks
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
adriansr
added
backport-v8.0.0
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Contributor
Author
|
CI failing under Windows recently due to python venv issues. Merging anyway. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2022
This restores the `@timestamp` field in Filebeat's module tests, so that it is properly validated. Temporarily disable timestamp validation in ibmmq module (cherry picked from commit bcb83e8)
adriansr
added a commit
that referenced
this pull request
Jan 10, 2022
This restores the `@timestamp` field in Filebeat's module tests, so that it is properly validated. Temporarily disable timestamp validation in ibmmq module (cherry picked from commit bcb83e8) Co-authored-by: Adrian Serrano <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jan 12, 2022
…b-for-macos * upstream/master: (172 commits) [Elastic Agent] Fix issue with ensureServiceToken. (elastic#29800) [Winlogbeat] Add provider name to Security routing pipeline check (elastic#29781) Add summary to journeys which don't emit journey:end (early node subprocess exits) (elastic#29606) Prepare 8.0.0-rc1 changelog (elastic#29795) (elastic#29806) Change docker image from CentOS 7 to Ubuntu 20.04 (elastic#29681) libbeat/processors/add_process_metadata: implement a process cache eviction policy (elastic#29717) [Automation] Update elastic stack version to 8.1.0-7004acda for testing (elastic#29783) Missing changelog entry for elastic#29773 (elastic#29791) Add a readme for k8s autodiscover provider (elastic#28213) Remove overriding of index pattern on the Kubernetes overview dashboard (elastic#29676) jjbb: remove obsoleted branches (<7.16) (elastic#29707) Add k8s metadata in state_cronjob metricset (elastic#29572) ibmmq: Fix timestamp parsing (elastic#29773) Do not add date to index if `@meta.index` is set (elastic#29775) ci: uses aliases for the branches (elastic#29706) Filebeat tests: Restore `@timestamp` field validation (elastic#29772) Forward port 7.16.3 changelog to master (elastic#29777) auditd: Store program arguments in process.args array (elastic#29601) System/socket: Support kernel_clone() replacement for _do_fork() (elastic#29744) Do not mention removal if version is not specified in `cfgwarn` messages (elastic#29727) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores validation for
@timestampfield in Filebeat's modules tests. This includes re-generating the expected files as they have been out of date for a while, and some of them had their@timestampfield lost since they've been updated.Why is it important?
Since #28450,
@timestampvalidation was disabled for Filebeat modules. Restoring it ensures we catch bugs related to extracting the correct timestamp from logs.Note: This temporarily disables validation for
ibmmq.errorlog, as there's a bug parsing timestamps in that fileset. This will be fixed in a separate PR. (here #29773)Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.