Skip to content

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 22, 2021

What does this PR do?

This PR adds support for latest k8s versions, v1.22 and v1.23.

We also need to consider dropping support for older versions that k8s does not support based on https://endoflife.date/kubernetes and https://kubernetes.io/releases/.

@MichaelKatsoulis @tetianakravchenko @jsoriano I would love your thoughts on this one. I can create follow up issues for this to discuss it there instead of blocking this one.

This came up after dealing with failures at #29572 since the Cronjob API move to batch/v1 at 1.21 and hence tests are failing for k8s version pior to 1.20.

elastic-package: elastic/elastic-package#634
integrations: elastic/integrations#2372

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Dec 22, 2021
@ChrsMark ChrsMark self-assigned this Dec 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 22, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 22, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-23T11:44:42.695+0000

  • Duration: 127 min 37 sec

  • Commit: 17e0257

Test stats 🧪

Test Results
Failed 0
Passed 48113
Skipped 4148
Total 52261

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Signed-off-by: chrismark <[email protected]>
@ChrsMark
Copy link
Member Author

/test

@ChrsMark ChrsMark requested a review from a team as a code owner December 23, 2021 09:03
@botelastic botelastic bot added the Team:Automation Label for the Observability productivity team label Dec 23, 2021
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@MichaelKatsoulis
Copy link
Contributor

@MichaelKatsoulis @tetianakravchenko @jsoriano I would love your thoughts on this one. I can create follow up issues for this to discuss it there instead of blocking this one.

We can discuss this in a separate issue. But on the top of my head I believe we should drop support for k8s versions that kubernetes has also dropped support.

@ChrsMark ChrsMark added the backport-v8.1.0 Automated backport with mergify label Dec 23, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Dec 23, 2021
@ChrsMark ChrsMark merged commit 78e1c58 into elastic:master Dec 23, 2021
@ChrsMark ChrsMark mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v8.1.0 Automated backport with mergify Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants