-
Notifications
You must be signed in to change notification settings - Fork 5k
x-pack/packetbeat: add licensing notices and information for Npcap #29303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
x-pack/packetbeat/LICENSE-Npcap.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this directory the right place for this or should it go in the root with additional words to note who it's relevant to — it probably already needs some of that to note that it's only relevant to Windows users. Note that currently this file doe not get placed on the target system — should it be?
x-pack/packetbeat/magefile.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this wording OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a place-holder file. It should probably also have a link to the canonical license file to avoid risk of errors.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
b159725 to
d4c2496
Compare
1344a47 to
3bc0aa7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Also make test failures log mock installer output.
7f35287 to
0c806cc
Compare
8260116 to
3f24c09
Compare
|
/test |
|
/package |
3f24c09 to
436d960
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
436d960 to
eb6c75b
Compare
x-pack/packetbeat/magefile.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While debugging the license checking issues I found that this is not run during packaging. This means that this hold won't constrain the license note customisation though it will prevent escape of the actual installer. Is this a problem and if it is where would be the best equivalent place in the packaging code path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this block is not necessary (or I don't understand something). All artifacts produced by running mage package from beats/x-pack/packetbeat directory are ELv1 (and all artifacts from beats/packetbeat are ASL2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. This was a defensive inclusion in case beats/x-pack/packetbeat was moved to ELv2 which was something that was raised as a concern.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
|
/test |
|
/test |
4ab7896 to
ecd9308
Compare
|
/package |
e475abf to
a58e5e5
Compare
|
Abandoned in favour of #29112. |
What does this PR do?
This adds licensing notices and information for #29112.
Why is it important?
This information is a legal requirement for distributing OEM Npcap. The PR is split to ease review.
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
This PR is almost entirely English semantics, comprehension is testing.
Only the final commit in this PR is new. The remainder are from #29112.
Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A