[Metricbeat] gcp.gke: uniform metric's fields#28368
Merged
endorama merged 5 commits intoelastic:masterfrom Oct 14, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
6 tasks
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
paolafrancesca
approved these changes
Oct 13, 2021
b1400bb to
534efb4
Compare
endorama
added a commit
that referenced
this pull request
Oct 14, 2021
(cherry picked from commit 568fd05)
endorama
added a commit
that referenced
this pull request
Oct 14, 2021
…28433) Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uniform
gcp.gkefields.ymlfile: flatten and sort fields, addTestFetchintegration test and fix resulting missing fields.Why is it important?
As part of #27974 this PR uniform
gcp.gkemetricset fields.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
TEST_TAGS=gcp MODULE=gcp mage goIntegTestfields.gobefore mergingHow to test this PR locally
Related issues
Use cases
Screenshots
Logs