Skip to content

Conversation

@fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jun 29, 2021

Cherry-pick of PR #26251 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

Update go-structform to 0.0.9

Why is it important?

Introduce support to not report (json encode) struct fields that implement IsZero and have omitempty set.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2021
@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2021
@elasticmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26594 opened

  • Start Time: 2021-06-29T23:01:37.311+0000

  • Duration: 101 min 4 sec

  • Commit: f55e077

Test stats 🧪

Test Results
Failed 0
Passed 47299
Skipped 5291
Total 52590

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 2

Expand to view the steps failures

Google Storage Download
  • Took 2 min 54 sec . View more details on here
  • Description: [2021-06-30T00:17:49.659Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:
Checks if running on a Unix-like node
  • Took 0 min 0 sec . View more details on here

Log output

Expand to view the last 100 lines of log output

[2021-06-30T00:40:45.839Z] 
[2021-06-30T00:40:45.839Z] - generated xml file: C:\Users\jenkins\workspace\PR-26594-1-a9c98a9a-e00b-4852-9ff8-1249f520f574\src\github.com\elastic\beats\filebeat\build\TEST-python-unit.xml -
[2021-06-30T00:40:45.839Z] ============================ slowest 20 durations =============================
[2021-06-30T00:40:45.839Z] 15.89s call     filebeat/tests/system/test_harvester.py::Test::test_close_timeout
[2021-06-30T00:40:45.839Z] 6.10s call     filebeat/tests/system/test_registrar.py::Test::test_restart_state
[2021-06-30T00:40:45.839Z] 5.55s call     filebeat/tests/system/test_shutdown.py::Test::test_shutdown_wait_timeout
[2021-06-30T00:40:45.839Z] 4.69s call     filebeat/tests/system/test_input.py::Test::test_harvester_limit
[2021-06-30T00:40:45.839Z] 4.58s call     filebeat/tests/system/test_crawler.py::Test::test_encodings
[2021-06-30T00:40:45.839Z] 4.55s call     filebeat/tests/system/test_reload_inputs.py::Test::test_reload_add
[2021-06-30T00:40:45.839Z] 4.35s call     filebeat/tests/system/test_crawler.py::Test::test_multiple_appends
[2021-06-30T00:40:45.839Z] 3.83s call     filebeat/tests/system/test_input.py::Test::test_close_inactive_file_rotation_and_removal2
[2021-06-30T00:40:45.839Z] 3.77s call     filebeat/tests/system/test_multiline.py::Test::test_close_timeout_with_multiline
[2021-06-30T00:40:45.839Z] 3.76s call     filebeat/tests/system/test_input.py::Test::test_rotating_close_inactive_low_write_rate
[2021-06-30T00:40:45.839Z] 3.64s call     filebeat/tests/system/test_reload_inputs.py::Test::test_start_stop_replace
[2021-06-30T00:40:45.839Z] 3.62s call     filebeat/tests/system/test_reload_inputs.py::Test::test_reload_same_input
[2021-06-30T00:40:45.839Z] 3.60s call     filebeat/tests/system/test_reload_inputs.py::Test::test_reload_same_config
[2021-06-30T00:40:45.839Z] 3.55s call     filebeat/tests/system/test_registrar.py::Test::test_state_after_rotation
[2021-06-30T00:40:45.839Z] 3.54s call     filebeat/tests/system/test_registrar.py::Test::test_state_after_rotation_ignore_older
[2021-06-30T00:40:45.839Z] 3.46s call     filebeat/tests/system/test_reload_inputs.py::Test::test_start_stop
[2021-06-30T00:40:45.839Z] 3.44s call     filebeat/tests/system/test_reload_modules.py::Test::test_start_stop
[2021-06-30T00:40:45.839Z] 3.31s call     filebeat/tests/system/test_shutdown.py::Test::test_shutdown
[2021-06-30T00:40:45.839Z] 2.81s call     filebeat/tests/system/test_multiline.py::Test::test_timeout
[2021-06-30T00:40:45.839Z] 2.48s call     filebeat/tests/system/test_registrar.py::Test::test_registrar_files_with_input_level_processors
[2021-06-30T00:40:45.839Z] ================ 165 passed, 185 skipped in 208.77s (0:03:28) =================
[2021-06-30T00:40:46.101Z] >> python test: Unit Testing Complete
[2021-06-30T00:40:46.651Z] 
[2021-06-30T00:40:46.651Z] C:\Users\jenkins\workspace\PR-26594-1-a9c98a9a-e00b-4852-9ff8-1249f520f574\src\github.com\elastic\beats>FOR / %d IN ("ve") DO @IF EXIST "%d" rmdir /s /q "%d" 
[2021-06-30T00:40:49.526Z] 
[2021-06-30T00:40:49.526Z] C:\Users\jenkins\workspace\PR-26594-1-a9c98a9a-e00b-4852-9ff8-1249f520f574\src\github.com\elastic\beats>python .ci/scripts/pre_archive_test.py 
[2021-06-30T00:40:54.810Z] Copy .\filebeat\build into build\filebeat\build
[2021-06-30T00:40:54.810Z] Copy .\filebeat\null\build into build\filebeat\null\build
[2021-06-30T00:40:54.888Z] Running in C:\Users\jenkins\workspace\PR-26594-1-a9c98a9a-e00b-4852-9ff8-1249f520f574\src\github.com\elastic\beats\build
[2021-06-30T00:40:54.936Z] Recording test results
[2021-06-30T00:40:55.383Z] + gsutil --version
[2021-06-30T00:40:56.813Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-06-30T00:40:58.172Z] [Checks API] No suitable checks publisher found.
[2021-06-30T00:40:58.613Z] + gcloud auth activate-service-account --key-file ****
[2021-06-30T00:40:58.832Z] 
[2021-06-30T00:40:58.833Z] C:\Users\jenkins\workspace\PR-26594-1-a9c98a9a-e00b-4852-9ff8-1249f520f574\src\github.com\elastic\beats>go clean -modcache 
[2021-06-30T00:40:59.184Z] Activated service account credentials for: [[email protected]]
[2021-06-30T00:40:59.855Z] + gsutil -m -q cp -a public-read cGFja2V0YmVhdC13aW5kb3dzLTctMzItd2luZG93cy03LTMyLWJpdGY1NWUwNzdmNDk0Njg2NzI3NmQxZjk4OGY0ZThlNmVjNGM5OTljNjg gs://beats-ci-temp/ci/cache/
[2021-06-30T00:41:16.308Z] tests\system\test_http_endpoint.py ...................                   [ 14%]
[2021-06-30T00:41:16.308Z] tests\system\test_xpack_modules.py sssssssssssssssssssssssssssssssssssss [ 36%]
[2021-06-30T00:41:16.308Z] ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 79%]
[2021-06-30T00:41:16.585Z] ssssssssssssssssssssssssssssssssss                                       [100%]
[2021-06-30T00:41:16.585Z] 
[2021-06-30T00:41:16.585Z] - generated xml file: C:\Users\jenkins\workspace\PR-26594-1-53b5f06c-a692-4ce3-8e38-1ad2a91abd5b\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-python-unit.xml -
[2021-06-30T00:41:16.585Z] ============================ slowest 20 durations =============================
[2021-06-30T00:41:16.585Z] 3.56s call     x-pack/filebeat/tests/system/test_filebeat_xpack.py::FilebeatXPackTest::test_export_index_pattern_migration
[2021-06-30T00:41:16.585Z] 3.45s call     x-pack/filebeat/tests/system/test_filebeat_xpack.py::FilebeatXPackTest::test_export_index_pattern
[2021-06-30T00:41:16.585Z] 3.04s call     x-pack/filebeat/tests/system/test_filebeat_xpack.py::FilebeatXPackTest::test_export_template
[2021-06-30T00:41:16.585Z] 2.15s call     x-pack/filebeat/tests/system/test_filebeat_xpack.py::FilebeatXPackTest::test_export_config
[2021-06-30T00:41:16.585Z] 2.00s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_request
[2021-06-30T00:41:16.585Z] 1.93s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_malformed_json
[2021-06-30T00:41:16.585Z] 1.84s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_request_multiple_documents
[2021-06-30T00:41:16.585Z] 1.83s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_get_request
[2021-06-30T00:41:16.585Z] 1.82s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_request_ndjson
[2021-06-30T00:41:16.585Z] 1.80s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_valid_hmac
[2021-06-30T00:41:16.585Z] 1.80s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_invalid_hmac
[2021-06-30T00:41:16.586Z] 1.78s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_empty_body
[2021-06-30T00:41:16.586Z] 1.77s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_include_headers_empty_value
[2021-06-30T00:41:16.586Z] 1.77s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_correct_auth_header
[2021-06-30T00:41:16.586Z] 1.76s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_include_headers_without_header
[2021-06-30T00:41:16.586Z] 1.75s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_include_headers_not_canonical_header
[2021-06-30T00:41:16.586Z] 1.75s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_include_headers_single_value
[2021-06-30T00:41:16.586Z] 1.74s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_preserve_original_event
[2021-06-30T00:41:16.586Z] 1.72s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_wrong_content_header
[2021-06-30T00:41:16.586Z] 1.72s call     x-pack/filebeat/tests/system/test_http_endpoint.py::Test::test_http_endpoint_wrong_auth_header
[2021-06-30T00:41:16.586Z] ====================== 24 passed, 143 skipped in 47.64s =======================
[2021-06-30T00:41:16.586Z] >> python test: Unit Testing Complete
[2021-06-30T00:41:17.098Z] 
[2021-06-30T00:41:17.098Z] C:\Users\jenkins\workspace\PR-26594-1-53b5f06c-a692-4ce3-8e38-1ad2a91abd5b\src\github.com\elastic\beats>FOR / %d IN ("ve") DO @IF EXIST "%d" rmdir /s /q "%d" 
[2021-06-30T00:41:19.340Z] 
[2021-06-30T00:41:19.341Z] C:\Users\jenkins\workspace\PR-26594-1-53b5f06c-a692-4ce3-8e38-1ad2a91abd5b\src\github.com\elastic\beats>python .ci/scripts/pre_archive_test.py 
[2021-06-30T00:41:20.278Z] Copy .\x-pack\filebeat\build into build\x-pack\filebeat\build
[2021-06-30T00:41:20.278Z] Copy .\x-pack\filebeat\null\build into build\x-pack\filebeat\null\build
[2021-06-30T00:41:20.334Z] Running in C:\Users\jenkins\workspace\PR-26594-1-53b5f06c-a692-4ce3-8e38-1ad2a91abd5b\src\github.com\elastic\beats\build
[2021-06-30T00:41:20.400Z] Recording test results
[2021-06-30T00:41:22.340Z] [Checks API] No suitable checks publisher found.
[2021-06-30T00:41:22.922Z] 
[2021-06-30T00:41:22.922Z] C:\Users\jenkins\workspace\PR-26594-1-53b5f06c-a692-4ce3-8e38-1ad2a91abd5b\src\github.com\elastic\beats>go clean -modcache 
[2021-06-30T00:42:08.726Z] + gsutil --version
[2021-06-30T00:42:10.160Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-06-30T00:42:10.573Z] + gcloud auth activate-service-account --key-file ****
[2021-06-30T00:42:11.143Z] Activated service account credentials for: [[email protected]]
[2021-06-30T00:42:11.596Z] + gsutil -m -q cp -a public-read ZmlsZWJlYXQtd2luZG93cy0xMC13aW5kb3dzLTEwZjU1ZTA3N2Y0OTQ2ODY3Mjc2ZDFmOTg4ZjRlOGU2ZWM0Yzk5OWM2OA gs://beats-ci-temp/ci/cache/
[2021-06-30T00:42:32.661Z] + gsutil --version
[2021-06-30T00:42:34.091Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-06-30T00:42:34.497Z] + gcloud auth activate-service-account --key-file ****
[2021-06-30T00:42:35.066Z] Activated service account credentials for: [[email protected]]
[2021-06-30T00:42:35.493Z] + gsutil -m -q cp -a public-read eC1wYWNrL2ZpbGViZWF0LXdpbmRvd3MtMTAtd2luZG93cy0xMGY1NWUwNzdmNDk0Njg2NzI3NmQxZjk4OGY0ZThlNmVjNGM5OTljNjg gs://beats-ci-temp/ci/cache/
[2021-06-30T00:42:39.427Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-06-30T00:42:39.535Z] Stage "Packaging-Pipeline" skipped due to earlier failure(s)
[2021-06-30T00:42:39.691Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-26594/src/github.com/elastic/beats
[2021-06-30T00:42:40.350Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-26594
[2021-06-30T00:42:40.465Z] [INFO] getVaultSecret: Getting secrets
[2021-06-30T00:42:40.520Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-06-30T00:42:41.661Z] + chmod 755 generate-build-data.sh
[2021-06-30T00:42:41.661Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26594/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26594/runs/1 FAILURE 6064075
[2021-06-30T00:42:41.661Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26594/runs/1/steps/?limit=10000 -o steps-info.json

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 47299
Skipped 5291
Total 52590

@fearful-symmetry fearful-symmetry merged commit f71f0aa into elastic:7.x Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport review Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants