Migrate sqs metricset to use cloudwatch input as light weight module #26117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to migrate
sqsmetricset to usecloudwatchinput as light weight module. Two main parts in this PR:In the original
sqsmetricset, we are also making SQSListQueuesAPI call to get metadata for each SQS instance. This is added as a part ofcloudwatchmetricset now.You can see under
sqsmetricset, there is only amanifest.ymlfile which defines cloudwatch as the input.We need to keep backward compatibility with metric names so the dashboard can still be used.
You can see rename processor is used in
manifest.ymlfile under rds metricset to make sure with this PR we are not introducing breaking changes. Also please check the updateddata.jsonfile insqsmetricset to see the renaming is effective.Why is it important?
With this change, we no longer need to maintain the common code in both
sqsmetricset and cloudwatch metricset.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.