Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 1, 2021

What does this PR do?

This PR is to migrate rds metricset to use cloudwatch input as light weight module. Two main parts in this PR:

In the original rds metricset, we are also making RDS DescribeDBInstances API call to get metadata for each RDS instance. This is added as a part of cloudwatch metricset now.
You can see under rds metricset, there is only a manifest.yml file which defines cloudwatch as the input.

We need to keep backward compatibility with metric names so the dashboard can still be used.
You can see rename processor is used in manifest.yml file under rds metricset to make sure with this PR we are not introducing breaking changes. Also please check the updated data.json file in rds metricset to see the renaming is effective.

Why is it important?

With this change, we no longer need to maintain the common code in both rds metricset and cloudwatch metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 1, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 1, 2021
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Jun 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user kaiyan-sheng

  • Start Time: 2021-06-03T22:20:50.054+0000

  • Duration: 105 min 12 sec

  • Commit: 4b1671d

Test stats 🧪

Test Results
Failed 0
Passed 8634
Skipped 2483
Total 11117

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8634
Skipped 2483
Total 11117

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b refactor_rds upstream/refactor_rds
git merge upstream/master
git push upstream refactor_rds

@kaiyan-sheng kaiyan-sheng requested a review from ChrsMark June 4, 2021 00:11
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@kaiyan-sheng kaiyan-sheng merged commit 0ba849c into elastic:master Jun 4, 2021
@kaiyan-sheng kaiyan-sheng deleted the refactor_rds branch June 4, 2021 16:58
@kaiyan-sheng kaiyan-sheng added v7.14.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 4, 2021
kaiyan-sheng added a commit that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants