-
Notifications
You must be signed in to change notification settings - Fork 5k
Migrate rds metricset to use cloudwatch input as light weight module #26077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
ChrsMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
What does this PR do?
This PR is to migrate
rdsmetricset to use cloudwatch input as light weight module. Two main parts in this PR:In the original
rdsmetricset, we are also making RDSDescribeDBInstancesAPI call to get metadata for each RDS instance. This is added as a part ofcloudwatchmetricset now.You can see under
rdsmetricset, there is only amanifest.ymlfile which defines cloudwatch as the input.We need to keep backward compatibility with metric names so the dashboard can still be used.
You can see rename processor is used in
manifest.ymlfile underrdsmetricset to make sure with this PR we are not introducing breaking changes. Also please check the updated data.json file inrdsmetricset to see the renaming is effective.Why is it important?
With this change, we no longer need to maintain the common code in both
rdsmetricset andcloudwatchmetricset.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.