Skip to content

[Filebeat] Rename rsa.misc.hardware_id to observer.serial_number for fortinet.fortimail and fortinet.fortimanager modules #25356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Filebeat] Rename rsa.misc.hardware_id to observer.serial_number for fortinet.fortimail and fortinet.fortimanager modules #25356

wants to merge 1 commit into from

Conversation

@legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Apr 28, 2021

What does this PR do?

Renames rsa.misc.hardware_id to observer.serial_number for fortinet.fortimail and fortinet.fortimanager modules

Why is it important?

Sets the observer.serial_number ECS field

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd beats/x-pack/filebeat
TESTING_FILEBEAT_MODULES=fortinet mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2021
@botelastic
Copy link

botelastic bot commented Apr 28, 2021

This pull request doesn't have a Team:<team> label.

@legoguy1000 legoguy1000 force-pushed the 25254-fortimail-serial-number branch from 556cee4 to 866656f Compare April 28, 2021 00:06
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 28, 2021

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Pull request #25356 updated

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-04-28T00:07:41.182+0000

  • Duration: 4 min 51 sec

  • Commit: 866656f

Trends 🧪

Image of Build Times

Steps errors 2

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details on here
  • Description: approval-list/elastic/beats.yml
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output 

[2021-04-28T00:09:33.409Z]  > git config core.sparsecheckout # timeout=10
[2021-04-28T00:09:33.413Z]  > git checkout -f 866656f9cacbcc13ef6254d9e2cd44328cb9566e # timeout=15
[2021-04-28T00:09:35.029Z] Merge succeeded, producing 866656f9cacbcc13ef6254d9e2cd44328cb9566e
[2021-04-28T00:09:35.029Z] Checking out Revision 866656f9cacbcc13ef6254d9e2cd44328cb9566e (PR-25356)
[2021-04-28T00:09:34.998Z]  > git remote # timeout=10
[2021-04-28T00:09:35.003Z]  > git config --get remote.origin.url # timeout=10
[2021-04-28T00:09:35.007Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-28T00:09:35.011Z]  > git merge f1fea95e8d44b5b6c45a7d25026e6276f7248456 # timeout=10
[2021-04-28T00:09:35.022Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-04-28T00:09:35.031Z]  > git config core.sparsecheckout # timeout=10
[2021-04-28T00:09:35.035Z]  > git checkout -f 866656f9cacbcc13ef6254d9e2cd44328cb9566e # timeout=15
[2021-04-28T00:09:40.014Z] Commit message: "25254: Rename `rsa.misc.hardware_id` to `observer.serial_number`"
[2021-04-28T00:09:40.015Z] First time build. Skipping changelog.
[2021-04-28T00:09:40.015Z] Cleaning workspace
[2021-04-28T00:09:41.230Z] Timeout set to expire in 3 hr 0 min
[2021-04-28T00:09:41.241Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-04-28T00:09:41.656Z] [INFO] Number of builds to be searched 10
[2021-04-28T00:09:41.713Z] [INFO] Let's stop build #1. Aborted from #2
[2021-04-28T00:09:40.017Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-28T00:09:40.020Z] Resetting working tree
[2021-04-28T00:09:40.021Z]  > git reset --hard # timeout=10
[2021-04-28T00:09:40.105Z]  > git clean -fdx # timeout=10
[2021-04-28T00:09:42.424Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-04-28T00:09:42.437Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-25356/src/github.com/elastic/beats
[2021-04-28T00:09:42.453Z] [INFO] gitCheckout: Checkout SCM PR-25356 with default customisation from the Item.
[2021-04-28T00:09:42.475Z] [INFO] Override default checkout
[2021-04-28T00:09:42.505Z] Sleeping for 10 sec
[2021-04-28T00:09:52.526Z] The recommended git tool is: git
[2021-04-28T00:09:52.580Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-04-28T00:09:52.590Z] Wiping out workspace first.
[2021-04-28T00:09:52.600Z] Cloning the remote Git repository
[2021-04-28T00:09:52.600Z] Using shallow clone with depth 10
[2021-04-28T00:09:52.600Z] Avoid fetching tags
[2021-04-28T00:09:52.614Z] Cloning repository [email protected]:elastic/beats.git
[2021-04-28T00:09:52.641Z]  > git init /var/lib/jenkins/workspace/Beats_beats_PR-25356/src/github.com/elastic/beats # timeout=10
[2021-04-28T00:09:52.648Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2021-04-28T00:09:52.648Z]  > git --version # timeout=10
[2021-04-28T00:09:52.652Z]  > git --version # 'git version 2.17.1'
[2021-04-28T00:09:52.652Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-28T00:09:52.656Z]  > git fetch --no-tags --progress -- [email protected]:elastic/beats.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-04-28T00:10:13.125Z] Cleaning workspace
[2021-04-28T00:10:13.137Z] Using shallow fetch with depth 10
[2021-04-28T00:10:13.138Z] Pruning obsolete local branches
[2021-04-28T00:10:13.108Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2021-04-28T00:10:13.111Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-28T00:10:13.120Z]  > git config remote.origin.url [email protected]:elastic/beats.git # timeout=10
[2021-04-28T00:10:13.127Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-28T00:10:13.130Z] No valid HEAD. Skipping the resetting
[2021-04-28T00:10:13.130Z]  > git clean -fdx # timeout=10
[2021-04-28T00:10:13.140Z] Fetching upstream changes from [email protected]:elastic/beats.git
[2021-04-28T00:10:13.140Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-28T00:10:13.145Z]  > git fetch --no-tags --progress --prune -- [email protected]:elastic/beats.git +refs/pull/25356/head:refs/remotes/origin/PR-25356 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-04-28T00:10:14.164Z] Merging remotes/origin/master commit f1fea95e8d44b5b6c45a7d25026e6276f7248456 into PR head commit 866656f9cacbcc13ef6254d9e2cd44328cb9566e
[2021-04-28T00:10:15.743Z] Merge succeeded, producing 866656f9cacbcc13ef6254d9e2cd44328cb9566e
[2021-04-28T00:10:15.743Z] Checking out Revision 866656f9cacbcc13ef6254d9e2cd44328cb9566e (PR-25356)
[2021-04-28T00:10:14.166Z]  > git config core.sparsecheckout # timeout=10
[2021-04-28T00:10:14.169Z]  > git checkout -f 866656f9cacbcc13ef6254d9e2cd44328cb9566e # timeout=15
[2021-04-28T00:10:15.717Z]  > git remote # timeout=10
[2021-04-28T00:10:15.721Z]  > git config --get remote.origin.url # timeout=10
[2021-04-28T00:10:15.724Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-28T00:10:15.728Z]  > git merge f1fea95e8d44b5b6c45a7d25026e6276f7248456 # timeout=10
[2021-04-28T00:10:15.738Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-04-28T00:10:15.746Z]  > git config core.sparsecheckout # timeout=10
[2021-04-28T00:10:15.749Z]  > git checkout -f 866656f9cacbcc13ef6254d9e2cd44328cb9566e # timeout=15
[2021-04-28T00:10:16.887Z] Commit message: "25254: Rename `rsa.misc.hardware_id` to `observer.serial_number`"
[2021-04-28T00:10:16.887Z] Cleaning workspace
[2021-04-28T00:10:16.889Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-28T00:10:16.893Z] Resetting working tree
[2021-04-28T00:10:16.893Z]  > git reset --hard # timeout=10
[2021-04-28T00:10:16.978Z]  > git clean -fdx # timeout=10
[2021-04-28T00:10:18.429Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-04-28T00:10:19.028Z] + git fetch https://****:****@github.com/elastic/beats.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2021-04-28T00:11:26.818Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-25356/src/github.com/elastic/beats/.git
[2021-04-28T00:11:26.927Z] Archiving artifacts
[2021-04-28T00:11:27.673Z] + git rev-parse HEAD
[2021-04-28T00:11:27.988Z] + git rev-parse HEAD
[2021-04-28T00:11:28.287Z] + git rev-parse origin/pr/25356
[2021-04-28T00:11:28.325Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-04-28T00:11:28.673Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-04-28T00:11:29.577Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/beats/pulls/25356/reviews return 0 elements
[2021-04-28T00:11:29.604Z] [INFO] githubPrCheckApproved: Title: [Filebeat] Rename `rsa.misc.hardware_id` to `observer.serial_number` for `fortinet.fortimail` and `fortinet.fortimanager` modules - User: legoguy1000 - Author Association: CONTRIBUTOR
[2021-04-28T00:11:29.807Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-04-28T00:11:29.807Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-04-28T00:11:29.837Z] [INFO] Let's stop build #2. The PR is not allowed to run in the CI yet
[2021-04-28T00:11:29.848Z] Sleeping for 5 sec
[2021-04-28T00:11:30.799Z] Stage "Lint" skipped due to earlier failure(s)
[2021-04-28T00:11:30.825Z] Stage "Build&Test" skipped due to earlier failure(s)
[2021-04-28T00:11:30.851Z] Stage "Extended" skipped due to earlier failure(s)
[2021-04-28T00:11:30.877Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-04-28T00:11:30.903Z] Stage "Packaging-Pipeline" skipped due to earlier failure(s)
[2021-04-28T00:11:30.948Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-25356/src/github.com/elastic/beats
[2021-04-28T00:11:31.722Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-25356
[2021-04-28T00:11:31.953Z] [INFO] getVaultSecret: Getting secrets
[2021-04-28T00:11:31.987Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-28T00:11:32.636Z] + chmod 755 generate-build-data.sh
[2021-04-28T00:11:32.636Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25356/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25356/runs/2 ABORTED 231193
[2021-04-28T00:11:32.636Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25356/runs/2/steps/?limit=10000 -o steps-info.json
[2021-04-28T00:11:32.636Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25356/runs/2/tests/?status=FAILED -o tests-errors.json
[2021-04-28T00:11:32.886Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-04-28T00:11:33.797Z] Retry 2/3 exited 22, retrying in 2 seconds...

@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Apr 28, 2021

Closing, merging changes with #24816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Filebeat][Fortinet Module] Can we include hardware id in observer.serial_number in fortimail fileset, just in like firewall fileset?

2 participants

@legoguy1000 @elasticmachine