Skip to content

Fix broken generator tests, updates to go.sum needed (backport #25251)#25269

Merged
andrewkroh merged 1 commit into7.13from
mergify/bp/7.13/pr-25251
Apr 23, 2021
Merged

Fix broken generator tests, updates to go.sum needed (backport #25251)#25269
andrewkroh merged 1 commit into7.13from
mergify/bp/7.13/pr-25251

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 23, 2021

This is an automatic backport of pull request #25251 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)
@mergify mergify Bot added the backport label Apr 23, 2021
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 23, 2021
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Apr 23, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25269 opened

  • Start Time: 2021-04-23T12:03:43.835+0000

  • Duration: 26 min 17 sec

  • Commit: f083999

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

Copy link
Copy Markdown
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit df04b93 into 7.13 Apr 23, 2021
@mergify mergify Bot deleted the mergify/bp/7.13/pr-25251 branch April 23, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants